Skip to content

Conversation

@eddelbuettel
Copy link
Member

This simple PR addresses the issue raised in #1412 about the long-redundant helper functions that were prior to 2013 (!!) to constrct working src/Makevars* but have not been needed since.

A reverse-dependency check has been started. I will keep it as 'draft' until that is done (likely Monday).

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #1412 by adding informative deprecation messages to six helper functions (RcppLdPath, RcppLdFlags, CxxFlags, LdFlags, RcppCxx0xFlags, and Cxx0xFlags) that have been redundant since 2013. The messages use message() to gently notify users that these functions may be removed in 2027, with a recommendation to update their Makevars files.

Key Changes:

  • Added consistent deprecation messages to six long-redundant helper functions using message()
  • Updated ChangeLog to document the changes

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
R/RcppLdpath.R Added message() calls to six deprecated helper functions to inform users of their redundancy and potential future removal
ChangeLog Documented the addition of deprecation warnings via message() for the affected functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@eddelbuettel eddelbuettel marked this pull request as ready for review December 2, 2025 01:46
@eddelbuettel
Copy link
Member Author

This is ready for review as well now as the reverse-dependency run passed without any issues.

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit d65b66a into master Dec 2, 2025
32 checks passed
@eddelbuettel eddelbuettel deleted the feature/issue1412 branch December 2, 2025 13:07
eddelbuettel added a commit that referenced this pull request Dec 12, 2025
eddelbuettel added a commit that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants