Skip to content

Conversation

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 2, 2025

This PR removes the R file defining loadRcppModules() along with all documentation references to this long-deprecated function. Shrinking the package surface for once!

Draft for the two or so days the reverse dependencies will noodle over this. Flipped the bit to normal as the reverse depends check is progressing nicely.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@eddelbuettel eddelbuettel marked this pull request as ready for review December 2, 2025 20:40
@eddelbuettel
Copy link
Member Author

This change is coming up with a small repercussion: old(er) package rncl has an unused (!!) importFrom(Rcpp, loadRcppModules). I already sent a PR; as the package is used in a quite a few more we have a bit of an intersection with Rcpp:

> db <- tools::CRAN_package_db()
> rdrncl <- data.table(Package = tools::package_dependencies("rncl", reverse=TRUE, recursive=TRUE, db=db)[[1]])
> rdrcpp <- data.table(Package = tools::package_dependencies("Rcpp", reverse=TRUE, recursive=TRUE, db=db)[[1]])
> rdrcpp[rdrncl, on="Package"][, Package]
 [1] "CommEcol"      "phylobase"     "rotl"          "bivariatemaps" "adephylo"     
 [6] "adiv"          "DAISIEprep"    "ddtlcm"        "nodeSub"       "PCPS"         
[11] "phyext2"       "phylocanvas"   "phylosem"      "phylosignal"   "phyloTop"     
[16] "taxize"        "adespatial"    "EcoCleanR"     "taxotools"     "OCNet"        
[21] "eDITH"         "rivnet"       
> 

@eddelbuettel
Copy link
Member Author

Oh, but it looks otherwise fine. Can you review please, now that I flipped it to normal non-draft? Rev.dep check will be done later today.

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment above, I see a couple of places:

inst/skeleton/zzz.R:#    loadRcppModules()
inst/tinytest/testRcppModule/R/zzz.R:#    loadRcppModules()

These are chunks that have been long commented out, but maybe it's a good time to clean that up too.

exposed in the package namespace. The special value `TRUE` means that all
objects are exposed.

### Deprecated legacy method using loadRcppModules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole section should be removed, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and done in the new commits now pushed.

@eddelbuettel
Copy link
Member Author

Funny. I noticed commented-out chunks at other repos (when chasing the issue in rncl). Will clean that up and also revisit the vignette.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel
Copy link
Member Author

eddelbuettel commented Dec 3, 2025

Thanks for catching and highlighting those two issues I overlooked!

@eddelbuettel
Copy link
Member Author

Rev.dep check finished, report file committed

tl;dr:

  • rncl breaks, I already filed a small PR for it
  • rncl has a fair number of reverse dependencies, and those are taken down here too (six packages)
  • another spurious fail we had before, possibly due to opcode for a binary too new for the ancient machine used
  • a few packages that already have 'Deadline's set at CRAN fail again

So net-net a single 'change to worse' which we can address (with cooperation of its maintainer, that is)

@eddelbuettel eddelbuettel merged commit b83944e into master Dec 3, 2025
32 checks passed
@eddelbuettel eddelbuettel deleted the feature/issue1415 branch December 3, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants