-
-
Notifications
You must be signed in to change notification settings - Fork 219
Remove deprecated loadRcppModules (closes #1415) #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6e422f3
Remove deprecated loadRcppModules (closes #1415)
eddelbuettel d74c691
Tweak ChangeLog whitespace following rebase following #1416 merge
eddelbuettel 122be10
Remove section about deprecated loadRcppModules()
eddelbuettel b6c674f
Remove commented-out mentions of loadRcppModules()
eddelbuettel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,7 @@ | ||
|
|
||
| ## Up until R 2.15.0, the require("methods") is needed but (now) | ||
| ## triggers an warning from R CMD check | ||
| #.onLoad <- function(libname, pkgname){ | ||
| # #require("methods") ## needed with R <= 2.15.0 | ||
| # loadRcppModules() | ||
| #} | ||
|
|
||
|
|
||
| ## For R 2.15.1 and later this also works. Note that calling loadModule() triggers | ||
| ## For R 2.15.1 and later the approach shown here works (as opposed to the now removed | ||
| ## and long-deprecated `loadRcppModules()`. Note that calling loadModule() triggers | ||
| ## a load action, so this does not have to be placed in .onLoad() or evalqOnLoad(). | ||
| loadModule("NumEx", TRUE) | ||
| loadModule("yada", TRUE) | ||
| loadModule("stdVector", TRUE) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,6 @@ | ||
| # | ||
| #.onLoad <- function(libname, pkgname){ | ||
| # loadRcppModules() | ||
| #} | ||
|
|
||
| ## For R 2.15.1 and later this also works. Note that calling loadModule() triggers | ||
| ## For R 2.15.1 and later the approach shown here works (as opposed to the now removed | ||
| ## and long-deprecated `loadRcppModules()`. Note that calling loadModule() triggers | ||
eddelbuettel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ## a load action, so this does not have to be placed in .onLoad() or evalqOnLoad(). | ||
| loadModule("RcppModuleNumEx", TRUE) | ||
| loadModule("RcppModuleWorld", TRUE) | ||
| loadModule("stdVector", TRUE) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.