Skip to content

Columns can be filtered with/without traces : Fix #204#216

Merged
antoineatstariongroup merged 1 commit intodevelopmentfrom
feat/GH204-column-trace-filtering
Dec 16, 2022
Merged

Columns can be filtered with/without traces : Fix #204#216
antoineatstariongroup merged 1 commit intodevelopmentfrom
feat/GH204-column-trace-filtering

Conversation

@antoineatstariongroup
Copy link
Copy Markdown
Contributor

@antoineatstariongroup antoineatstariongroup commented Dec 16, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the UI-DSM code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #204

Inside views with traceability, columns can be filtered also depending if they has traces or not, same as rows.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.5% 96.5% Coverage
0.0% 0.0% Duplication

@antoineatstariongroup antoineatstariongroup merged commit 4848a05 into development Dec 16, 2022
@antoineatstariongroup antoineatstariongroup deleted the feat/GH204-column-trace-filtering branch December 16, 2022 09:56
antoineatstariongroup added a commit that referenced this pull request Jan 20, 2023
@antoineatstariongroup @martinatg
@martinrisseeuw @nabilatrhea @jaimeatstariongroup @lxatstariongroup
1.6.6 release (#276)
f7889cf 
* Base project architecture created : Fix #1

* Login and logout implemented : fix #3

* Login refactored : Fixes #3 #5

* User management implemented : Fix #8

* Alexander comment : Auto register for ViewModels

* Project management implemented : Fix #11

* RoleManagement implemented : Fix #14

* [Add] Code scanning - Build & Test & SonarQube GH Action; fixes #4

* Services and controllers refactored : Fix #15 (#20)

* Services and controllers refactored : Fix #15

* Bugs found resolved

* Try fix build failure

* Build failure

* Build failure again

* Try with mocking IJSRuntime

* Test fix build failure

* Test again

* try with async unit test

* Code smells fix

* REST API routes with Carter modules : Fix #21 (#23)

* Participant Service, API route, assembler and deep level : Fix #18, #24 (#25)

* Participant Service, API route, assembler and deep level : Fix #18, #24#

* Remove test that make everything fails

* Alex comment : Unique constraint to track duplication

* Does.Contain code smell fix

* User see project where he is participant: Fix #28 #30 (#31)

* User see project where he is participant: Fix #28 #30

* Bug fix

* Missed to test service method

* Alexander comment

* Add visual UI components & login functionality (#29)

* feat: add UI components

* feat: add visual components & login guard

* feat: add button styling

* feat: use slot for buttons

* chore: add .vscode to gitignore

* chore: add comments & remove nullable

* feat: add convention feedback

* chore: remove .vscode folder

* feat: add file headers

* feat: add some headers to pages

* chore: mainlayout styling

* chore: change file header names

* chore: add some comments

* chore: comments on appbutton

* chore: add comments

* chore: layout styling

* feat: review header

* chore: remove topmenu icons & styling changes

* chore: Update unit tests

* After rebase : conflicts resolved

* IJSObjectReference : try fix tests

* Try to fix tests

* bug fix

Co-authored-by: Martin Risseeuw <hello@martinr.nl>
Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* ReviewService and ReviewObjectiveService implemented : Fix #32 #33 (#41)

* ReviewService and ReviewObjectiveService implemented : Fix #32 #33

* Test failure

* Test failure remotly

* Test failure DxPopup issue

* Test failure again

* Test failure again, behaviour is not stable at all

* Another try

* Tries to catch all invocations

* setup module test

* Removed isVisible check on DxPopup

* setup module and invocation

* try catch

* Duplication and code smell fix

* feat: implement accordion + style changes (#44)

* feat: implement accordion + style changes

* Bug resolved

Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* Task, Annotation and Reply services : Fix #42 #43 #47 (#50)

* Task, Annotation and Reply services : Fix #42 #43 #47

* Code smell and duplication

* 48 UI implement three view  (#49)

* feat: add three component for specification

* Rebase and small code cleanup

Co-authored-by: Martin Risseeuw <hello@martinr.nl>
Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* feat: implement colors vars (#51)

Co-authored-by: Martin Risseeuw <hello@martinr.nl>

* Code generator implemented : Fix #52 #46 (#54)

* Code generator implemented : Fix #52

* Include new Test Project inside code coverage result

* Code coverage increased

* Newtonsoft is not used anymore : Fix #46

* Missing doc

* feat: add comment component & review description (#55)

* Upload from live session implemented : Fix #27 (#66)

* feat: added project pages and needed components (#60)

* feat: added project pages and needed components

* Index page is back

Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* 39 UI implement breadcrumb (#61)

* feat: add breadcrumb

* Rebase on dev

Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* feat: add traceability component (#64)

* A model can be uploaded by an Annex C3 file : Fix #26 (#69)

* A model can be uploaded by an Annex C3 file : Fix #26

* Code smell fix

* FileService update : allow relative path

* Update appsettings.json

* Manager refactor and remove autoinclude : Fix #40 #53 #67 (#71)

* Manager refactor and remove autoinclude : Fix #40 #53 #67

* Code smell fix

* User project, review and review objective pages : Fix #56 #58 #65 (#68)

* Project page with Review list

* Project review page with review attributes

* Add Project, Review, and Review Objective Pages

* Code smell and rebase

* fix file name in header and add missing documentation

Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* Forgot to include the properties at one point : Fix #79 (#80)

* Feat/gh78 link real data to project card and add new query to fetch review comments and tasks : Fix #78 #73 (#81)

* wip

* Add query for review to fetch tasks and comments, Link real data to project card : #73 #78

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* docker-compose files and scripts created : Fixes #13 (#82)

* docker-compose files and scripts created : Fixes #13

* Build failure fix

* Code coverage fix

* Code coverage

* The ThingService enable queries to get Things : Fix #72 (#83)

* The ThingService enable queries to get Things : Fix #72

* code smell

* Remove unused code

* Add TestFixture

* review creation : Fix #59  (#84)

* Add review creation in project page

* Pass Project's artifacts to ReviewCreation and get its models list

* code refactoring

* Add try catch to review creation test

* Try catch for DevExpress popup

* fix code smell and test coverage

* remove some code smell

* Code coverage fix

* Missing documentation

Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* 70 UI add traceability to page (#85)

* feat: add traceability page

* feat: switch viewpoints

* Bug fix and rebase

Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* ReviewObjective and ReviewTask creation : fix #76 (#86)

* ReviewObjective and ReviewTask creation : fix #76

* Fix build failure on GitHub

* feat: add filters (#92)

* feat: add requirement widget (#101)

* feat: add requirement widget

* Code smell fix and small change on AppKeyValues

Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* Review Category Management : Fix #75 (#123)

* Review Category Management and test fixture

* fix code duplication

* fix code coverage for serializers and deserializers

* add more code coverage on deserializers

* ReviewTaskPage, selectedItem and requirementbreakdown : Fix #91 #97 #98 #96 (#102)

* ReviewTaskPage, selectedItem and requirementbreakdown : Fix #91 #97 #98

* code smell and code coverage

* Fixed test failure

* Test failure

* Fix missing association

* IQuerable missing property fixed : Fix #96

* Sam's comment

* Build failure fixed

* ReviewItem and Commenting process : Fix #106 #100 #107 #108 #132 (#133)

* ReviewItem and Commenting process : Fix #106 #100 #107 #108 #132

* code smell fix

* Alex suggestion implemented

* Moved to Radzen

* Check failed at some times

* Participant management : Fix #104 (#134)

* Project participants management

* Project participants management

* update deletion part

* fix code smell

* add ContentText to the confirm cancel popup

* Reply system implemented: Fix #131 (#136)

* Reply system implemented: Fix #131

* Remove unused feature

* Fix test failure

* style components (#140)

Co-authored-by: Martin Risseeuw <hello@martinr.nl>

* All Traceability views implemented: Fix #113 #114 #137 #139 #122 #116 #115 (#138)

* 2 Traceability views implemented: Fix #113 #114 #137

* Duplication and code smell fix

* Rebase and fix #139, #122, #116, #115

* Build failure fixed

* Code smell and duplication fix

* Views implemented and moved to ElementUsage: Fix #110 #111 #112 #121 #141 (#144)

* Views implemented and moved to ElementUsage: Fix #110 #111 #112 #141

* Code smell and coverage increased

* TRLView implemented : Fix  #121

* feat: style traceability (#145)

Co-authored-by: Martin Risseeuw <hello@martinr.nl>

* Review Objectives creation and open tasks, comments computation in review : Fix #130 #90 #87 (#147)

* computation of comments using reviewItems and open tasks for current user

* adding projectId as a parameter to GetOpenTasksAndComments method in ReviewManager

* Review objectives creation

* review objectives creation with button status

* Add some test coverage

* add review objective module test

* handle js runtime in bunit test

* add test coverage and fix code smell

* fix code smell

* Interface View and RequirementVerificationControlView : Fix #119 #117 (#149)

* Interface View and RequirementVerificationControlView : Fix #119 #117

* Test with updated version of BUnit

* Try to fix test failure

* Test failures

* Switching to other views/task is possible : Fix #148 #57 (#159)

* Switching to other views/task is possible : Fix #148 #57

* Code coverage improved

* Missing test for copyComponents

* Code smell fix

* Fix typo and missing test

* Diagram with nodes can be created from products and ports (#154)

* Diagram with nodes can be created from products and ports

* Separate logic in ViewModel

* Fix test

* Change in failing test

* Added some tests to improve test coverage

* Add more tests

* Update failing test

* Add IReusableView interface

* Model selection available : Fix #157 (#163)

* Model selection available : Fix #157

* Code smell and build failure fix

* Added custom Nodes, Ports and Links; fixes #151 #153

* IEnumarable<string> to string for DxGrid + Assign Task to Participant + LoadingComponent : Fix #16 #129 #156 (#169)

* add comma seperated properties

* Task assignment and loading component

* ProductBreakdown and FunctionBreakdown option available : Fix #142 (#166)

* 146 style document view (#172)

* feat: add styling document view

* feat: style components

* feat: style components

* feat: update related views

* feat: update styling

* feat: adjust click area button

* feat: style traceability header

* Fix test

Co-authored-by: Martin Risseeuw <hello@martinr.nl>
Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* Add Legend, Reload when comments are changed and feedback on interface links; fix #155, #162, #170, #174

* ProjectManagement access right added : Fix #164 (#175)

* ProjectManagement access right added : Fix #164

* Fix test coverage

* Added collapsible legend; fix #177

* Include loading component, Change Iteration Uploads Diagram. fix#171 and #176

* ReviewItem can be set as Reviewed : Fix #168 (#182)

* ReviewItem can be set as Reviewed : Fix #168

* Rebase and adjust loadingComponent

* Rebase and fix some issue with loading component

* Mark a task as done or undone (#189)

* Model Details (#190) fix #188

* Number of Tasks and Comments in review objective and fix task assignment (#194)

* docker files update

* misspell ports property

* Update README.md

* Remove useless files

* If no project, unable to create one

* [Add] GH action to build and push docker container

* [Fix] path in dockerfile

* [Add] DOCKER_BUILDKIT=1

* [Update] dockerfile

* RouteParser and ReviewObjective status implemented : Fix #180 183 (#195)

* RouteParser and ReviewObjective status implemented : Fix #180 183

* code smell fix

* AboutPage and AboutService implemented: Fix #105 (#197)

* Version 1.1.0

* Folder architecture changed and DockerFile fixed

* Workflows fix

* codeQuality check

* Feat/gh184 assign task to multiple participants : Fix #184 (#206)

* assign task to multiple participants

* fix code coverage and duplication

* handle deletion of existing assigned participants

* add selected Particiants to retrieve the added one

* disable Assign button if the user has not selected a participant

* remove EditForm

* add the already assigned participants to selection

* fix code smell

* Prefilter, column at start, cost value and version : Fix #99 #198 #202 #167 #77 (#203)

* Prefilter, column at start, cost value and version : Fix #99 #198 #202

* Rebase fix

* Comment can be linked to other elements : Fix #167

* code smell fix

* Breadcrumb behaviour added

* test failure fix

* Version update

* More content inside context panel : Fix #160 (#207)

* More content inside context panel : Fix #160

* Code smell fix

* Code coverage

* 205 style UI components (#208)

* feat: style column chooser

* feat: update styling

* feat: update styling:

* Rebase and ConnectionVisibilitySelectorViewModel behaviour fixed

* Code coverage

* Tests fixed

Co-authored-by: Martin Risseeuw <hello@martinr.nl>

* Version update

* DynamicComponent is also reset : Fix #209 (#210)

* Bug fix when changing on same view type

* Test fix

* Participant deletion : Fix #196 (#211)

* mark review task as done wip

* delete comments, replies and remove assigned tasks to deleted participant

* fix code smell

* Navigation by double-clicking enabled : Fix #161 (#212)

* Navigation by double-clicking enabled : Fix #161

* Code coverage and reacts to link for comment

* Test coverage

* code smell fix

* Columns can be filtered with/without traces : Fix #204 (#216)

* Version update

* feat: update styles (#222)

Co-authored-by: Martin Risseeuw <hello@martinr.nl>

* Save diagram layout : Fix #213 (#225)

* Save diagram layout

* add name definition to layout configuration

* fix service test

* add popup test

* saving diagram layout

* fix code smell

* add ReviewTaskId field to BaseViewViewModel

* remove ReviewTaskId from InterfaceViewViewModel

* SearchService implemented : Fix #127 (#223)

* SearchService : Needs more unit test

* workflows

* Update CodeQuality.yml

* Update codeql-analysis.yml

* Unit tests added

* Code coverage

Co-authored-by: Alex Vorobiev <a.vorobiev@rheagroup.com>

* Search Page and Model Page implemented : Fix #224 #226 (#228)

* Search Page and Model Page implemented : Fix #224 #226

* Code smell and code coverage

* Add nodes instead of replacing them (#230)

* Add nodes instead of replacing them

* A comment is linked to a ReviewTask: Fix #217 (#231)

* A comment is linked to a ReviewTask: Fix #217

* Code smells

* Popup with SelectedItemBase component created : Fix #218 (#234)

* Popup with SelectedItemBase component created : Fix #218

* Code coverage and cleanup

* Code cleanup

* The user menu contains the name of the current role: Fix  #233 (#235)

* Assigned Participants are displayed : Fix #236 (#237)

* Load diagram configuration : Fix #214 (#241)

* loading layout configuration

* code coverage

* fix bug

* fix bug

* DoE is assigned to Participant : Fix #238 (#239)

* DoE is assigned to Participant : Fix #238

* Participant' domains of expertise are displayed

* Code coverage

* Update of dll for searchEngine

* AccessRight for saving diagram created : Fix #219 #242 #243 (#244)

* AccessRight for saving diagram created : Fix #219 #242 #243

* Code coverage

* Docker files update & Comments for ReviewTask:Fix #240 #232 (#245)

* Docker files update & Comments for ReviewTask:Fix #240 #232

* ReadMe and code coverage

* Fix link on first elements (#249)

* Filtering added, Center inside diagram and vertices: Fix #215 #248 #250 (#251)

* Filtering included. Save DiagramDto working

* Filtering added, Center inside diagram and vertices: Fix #215 #248 #250

* Code coverage

* Diagram is also initializes when copying component:Fix #252 (#253)

* Save-load modified, delete configuration enabled :Fix #254 #255 #257 (#258)

* 227 style UI components (#259)

* feat: update component styling

* feat: style search

* feat: update components

* Rebase on dev

* Rebase on dev again

Co-authored-by: Martin Risseeuw <hello@martinr.nl>
Co-authored-by: antoineatrhea <a.theate@rheagroup.com>

* Commenting on ModelPage enabled : Fix #256 (#262)

* Commenting on ModelPage enabled : Fix #256

* Code coverage and smell

* Navigation inside interfaceView and bug fix : Fix #260 #261 (#263)

* Navigation inside interfaceView and bug fix : Fix #260 261

* Remove unnecessary code

* Version update

* ui-dsm-search-service image and Bugs fixes: Fix #264 #265 #266 #267 (#268)

* Version update

* Missed search results

* Reporting (#269)

* Iteration is now indexed : Fix #271 (#272)

* Iteration is now indexed correctly: Fix #271

* Code coverage

* Rebase

* Version update

* dockerfile update

* Upgrade CDP4Reporting to official nuget (#274)

* UI updates 16 01 2023 (#273)

* update loading component

* higlight scroll in to view element

Co-authored-by: Martin Risseeuw <hello@martinr.nl>

* feat: search styling

* feat: style budget

* BudgetTemplate can be uploaded : Fix #270 (#275)

* BudgetTemplate can be uploaded : Fix #270

* Code coverage

* Version update

* style: add loading to app html

* Clear selected DoE

* Deletion exception fixed and switching fixed: Fix #278 #277 (#279)

* Deletion exception fixed and switching fixed: Fix #278 #277

* code coverage

* Version update

* Search page css updated

* Paging removed from requirement breakdown views

* Missing scroll inside RequirementBreakdown when focusing

* delete reply bug fix and link to relationship fix

* style update

Co-authored-by: sam.gerene <s.gerene@rheagroup.com>
Co-authored-by: martinatg <111426664+martinatg@users.noreply.github.com>
Co-authored-by: Martin Risseeuw <hello@martinr.nl>
Co-authored-by: nabilatrhea <112706228+nabilatrhea@users.noreply.github.com>
Co-authored-by: Jaime Bernar <112856984+jaimeatrhea@users.noreply.github.com>
Co-authored-by: Alex Vorobiev <a.vorobiev@rheagroup.com>
Co-authored-by: Alexander van Delft <56023674+lxatrhea@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omaratstariongroup omaratstariongroup omaratstariongroup approved these changes

@alexatstariongroup alexatstariongroup Awaiting requested review from alexatstariongroup

@jaimeatstariongroup jaimeatstariongroup Awaiting requested review from jaimeatstariongroup

@lxatstariongroup lxatstariongroup Awaiting requested review from lxatstariongroup

@nathanatstariongroup nathanatstariongroup Awaiting requested review from nathanatstariongroup

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Column filtering on TraceabilityTable

2 participants

@antoineatstariongroup @omaratstariongroup