Typed Column - #2794
Merged
Merged
Conversation
tyt2y3
force-pushed
the
typed-column
branch
3 times, most recently
from
November 6, 2025 01:52
305b721 to
e654503
Compare
Member
Author
|
Everything will pass after I bump sea-query |
tyt2y3
commented
Nov 6, 2025
Comment on lines
+185
to
+193
| let found = Entity::find() | ||
| .filter( | ||
| Entity::COLUMN | ||
| .teas | ||
| .overlap(vec![Tea::BreakfastTea, Tea::AfternoonTea]), | ||
| ) | ||
| .order_by_asc(Entity::COLUMN.id) | ||
| .all(db) | ||
| .await?; |
tyt2y3
marked this pull request as ready for review
November 7, 2025 20:07
Member
Author
|
release early, release often |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still WIP but I want everyone to see this earlier.
So basically after some research I figured we can have typed columns without the complexity of "one struct for every column", and this solution solves three things:
cake::Entitymore usefulWe would generate the following structs, columns share the same type so it's fine if Entity has 100 Columns:
The following would not compile:
This also means that
containsfor String would not collide witharray_contains.