This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Thecodepixi/move required args to session constructor#245
Closed
hgezim wants to merge 44 commits intoShopify:thecodepixi/move-required-args-to-session-constructorfrom
Closed
Conversation
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.6 to 4.7.7. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.7.6...v4.7.7) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.1. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.4.7...1.5.1) Signed-off-by: dependabot[bot] <support@github.com>
…andlebars-4.7.7 Bump handlebars from 4.7.6 to 4.7.7
…rl-parse-1.5.1 Bump url-parse from 1.4.7 to 1.5.1
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.3.2 to 10.7.2. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/10.7.2/CHANGES.md) - [Commits](highlightjs/highlight.js@10.3.2...10.7.2) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.2. - [Release notes](https://github.com/mikaelbr/node-notifier/releases) - [Changelog](https://github.com/mikaelbr/node-notifier/blob/master/CHANGELOG.md) - [Commits](mikaelbr/node-notifier@v8.0.0...v8.0.2) Signed-off-by: dependabot[bot] <support@github.com>
…osted-git-info-2.8.9 Bump hosted-git-info from 2.8.8 to 2.8.9
…ighlight.js-10.7.2 Bump highlight.js from 10.3.2 to 10.7.2
…odash-4.17.21 Bump lodash from 4.17.20 to 4.17.21
…ode-notifier-8.0.2 Bump node-notifier from 8.0.0 to 8.0.2
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.3. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/y18n-v4.0.3/CHANGELOG.md) - [Commits](yargs/y18n@v4.0.0...y18n-v4.0.3) Signed-off-by: dependabot[bot] <support@github.com>
…18n-4.0.3 Bump y18n from 4.0.0 to 4.0.3
Add support for PubSub webhook registration
Fix incorrect example in webhook register docs
…-hmac Don't include extra params when calculating local hmac
Change broken endpoint
Clean up code using @shopify/prettier-config
Update spelling on customsessions.md
Register webhooks section (Express) loadCurrentSession method uses `request` and `response` props instead of `req` and `res` as returned in the callback
Update webhooks.md - method uses incorrect prop variables
ghost
added
the
Author
|
@paulomarg Isthe CLA bot broke? I signed the CLA: |
Author
|
This is no longer needed as #169 was clarified by #169 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To fix merge conflict in #169.