[pull] master from getsentry:master#239
Merged
pull[bot] merged 44 commits intoSimenB:masterfrom Jul 29, 2025
Merged
Conversation
Before aggregate filters were causing the query to fail.
…e build details page (#96574) Leverages new Flex, Text & Heading components on the Emerge build details page: Before: <img width="1492" height="666" alt="Screenshot 2025-07-28 at 1 03 56 PM" src="https://github.com/user-attachments/assets/7c76e854-71ce-43d5-8be1-3e8501f7335a" /> After (no change as expected): <img width="1490" height="643" alt="Screenshot 2025-07-28 at 1 01 50 PM" src="https://github.com/user-attachments/assets/63c00429-99dc-4a90-a21e-1aaf57477f99" />
<!-- Describe your PR here. -->
This PR gets rid of the main default value for branch query parameter on the test_results endpoint as a) this endpoint does and can support `None` as a value and b) that was a placeholder value during testing
We are dogfooding the v10 alpha: https://github.com/getsentry/sentry/blob/82f640be370f447b29539928c904cafadba981a9/package.json#L71 but forgot to change the `enableLogs` flag. See https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md#2-removed-apis
…96607) We do not need this option anymore.
Closes https://linear.app/getsentry/issue/CCMRG-1437/onboarding-step-4 Closes https://linear.app/getsentry/issue/CCMRG-1438/onboarding-step-5 Closes https://linear.app/getsentry/issue/CCMRG-1439/onboarding-step-6 Figma file: https://www.figma.com/design/mSyCX0wCk7e2yItQfiMhaa/GH-1247_MergePlan?node-id=1-2&t=pUq7qhgXR70GkbJr-1 - Added new steps that are used for steps 4, 5, and 6. None currently have the step 6 label but depending on how many steps came before, the ViewResultsInsightsStep may be used for 6. - Added "Step" suffix to all of the step component names - Changed a couple instances of `space` to the new schema with theme
- Refactor code for pills in trace view **Before:** <img width="942" height="182" alt="Screenshot 2025-07-25 at 1 46 53 PM" src="https://github.com/user-attachments/assets/4cc4c556-3c1f-4c87-b4f4-cc37844b06db" /> <img width="508" height="143" alt="Screenshot 2025-07-25 at 1 49 43 PM" src="https://github.com/user-attachments/assets/1e59bc89-87a4-449a-a24e-e7180b31b480" /> **After:** <img width="946" height="175" alt="Screenshot 2025-07-25 at 1 46 39 PM" src="https://github.com/user-attachments/assets/a0a23946-e392-4b62-bddc-d98272811bd2" /> <img width="507" height="142" alt="Screenshot 2025-07-25 at 1 49 22 PM" src="https://github.com/user-attachments/assets/108c13b7-650f-42a1-9280-ad5701b84748" />
We can't log the raw redis data; it's too big, too noisy, and it yields broken JSON we can't query. This replaces that with two slightly more targeted data log messages to let us definitively identify involved workflows, and their associated groups/events. We prefer sorted lists over sets because sets log unordered and are hard to search through. Also, this moves from logging DataConditionGroups (which have a large and not particularly useful string repr) to just the sorted IDs.
… notification handler (#95735)
This uses typescript to enforce that only some routes are injected with the legacy router props. This way we can slowly reduce the components that require this react router 3 style prop. Removes the "NoOp" route component and renders undefined instead which react router 6 should just render the child? --------- Co-authored-by: Evan Purkhiser <evanpurkhiser@gmail.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Nav V2 is GAed and available for everyone (see [automator](https://github.com/getsentry/sentry-options-automator/blob/507cffc82679fc5aee370808a4b084dc6a416d27/options/default/flagpole.yml#L3538)), so we don't need the flag. Follow up to #95951.
resolves https://linear.app/getsentry/issue/LOGS-259/add-logs-to-ruby-onboarding <img width="1514" height="759" alt="image" src="https://github.com/user-attachments/assets/8cd30708-3715-43dc-9576-372720450416" />
…96661) we only care about the actual sorting here - the flagpole call was adding some noise. also adds a better description for the span
<img width="640" height="20" alt="SCR-20250729-jqrk" src="https://github.com/user-attachments/assets/660428c3-22bb-4dec-912c-4fd14f07baee" />
…96032) - Fix a bug where top events did not correctly work with array fields, and instead just ignored their existence entirely
…96674) We frequently see slow tasks from repeated latest release condition evaluations. This may be due to the cache not being used when releases aren't found. Adds caching and a metric to observe how much value it is adding. Also adds a typed cache access helper to clarify None vs False, which is a bit overkill for a single use but helpful nonetheless.
…xt (#96656) ### Changes [Merged a PR](#96323) a few days ago that fixed the vertical alignment the cells, but it messed up the alignment of the tooltip. This is to fix that while still persisting the fix for the vertical alignment ### Before <img width="324" height="145" alt="Screenshot 2025-07-29 at 11 48 08 AM" src="https://github.com/user-attachments/assets/b6e1e080-90b1-4244-a4e3-9f8bfaf91e16" /> ### After <img width="356" height="137" alt="Screenshot 2025-07-29 at 11 48 19 AM" src="https://github.com/user-attachments/assets/ee2c5cc3-2b24-4090-a918-112f9e9bd322" />
…form (#96678) Follow up from getsentry/sentry-options-automator#4702, cleaning up leftover option from rolling out inferring project platforms from #95402
this decorator caused anything decorated to become Any <!-- Describe your PR here. -->
Adds a new 'primitives' category to the storybook navigation tree to group fundamental layout and text components separately from other core components. - Add 'primitives' to StoryCategory type - Update category ordering to place primitives after foundations - Create isPrimitivesFile() to identify core/layout and core/text components - Modify inferFileCategory() to categorize primitives components correctly This improves component organization by creating a dedicated section for the most basic UI building blocks.
- Making sure that we have at least a base level of testing of the explore page - depends on #96578
<!-- Describe your PR here. -->
Add Grid layout primitive that follows the Flex conventions
Closes: https://linear.app/getsentry/issue/BIL-1178/logs-product-should-display-in-the-ui-as-logs-not-log-bytes Changes the display name for the Logs product. Affects the subscription card (shown below) as well as other labels in the application. <img width="1178" height="343" alt="Screenshot 2025-07-29 at 9 53 02 AM" src="https://github.com/user-attachments/assets/557821cd-998a-48f1-be60-c3ca6c13e102" />
<img width="856" height="694" alt="Screenshot 2025-07-29 at 9 47 43 AM" src="https://github.com/user-attachments/assets/606673d9-f62a-4c71-8a35-bfdef1ee1bc3" /> extracted time selector for metric detector chart to the details component so that it could be shared between the chart and table
…96666) This refactors the multi query mode to use the same shared chart visualization as other parts of explore.
…96610) Currently, we have inconsistent behavior when loading a grouping config with an id we don't recognize. If the config id comes from the project, and we've therefore gotten it by using `ProjectGroupingConfigLoader._get_config_id`, it's guaranteed to be one we've heard of, because if it's not, `_get_config_id` will instead return the id of the default config[1]. If instead the config id comes from an event's `grouping_config` entry (which we grab with no validation[2]), trying to load the grouping config will raise a `GroupingConfigNotFound` error[3]. To make the behavior consistent, this switches from raising the error in the latter case to just returning the default config. Since this was the only place we were raising `GroupingConfigNotFound`, this also lets us remove all of our handling of it, as well as the error class itself. [1] https://github.com/getsentry/sentry/blob/65fa0a9af7d186bc5142cf85e6fdb9a59e08a406/src/sentry/grouping/api.py#L147-L148 [2] https://github.com/getsentry/sentry/blob/65fa0a9af7d186bc5142cf85e6fdb9a59e08a406/src/sentry/grouping/api.py#L190 [3] https://github.com/getsentry/sentry/blob/65fa0a9af7d186bc5142cf85e6fdb9a59e08a406/src/sentry/grouping/api.py#L229-L230
This PR was auto-generated - it updates the \`jest-balance.json\` file with new test run data from CI. --------- Co-authored-by: JonasBa <JonasBa@users.noreply.github.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
This reverts commit 055056d. Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
…6685) just refreshes the current query this acceptance test below is testing this case, however it currently only passes because it attempts to navigate to the saved query directly after deleting (event propagation) therefore the card disappears and it passes. https://github.com/getsentry/sentry/blob/195d6990b8a694ee733a1483e0b3f7486b53a5f4/tests/acceptance/test_organization_events_v2.py#L447-L472
these pages are only accessible by orgs who had the legacy feature but we don't want any orgs to be able to use this anymore. After we remove the pages from the front end, we will clean up the backend. fixes https://linear.app/getsentry/issue/RTC-1091/remove-rate-limit-pages-from-the-front-end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )