[Alpha 19.3.1] Prayer Comments List Block Throws Exceptions With Custom Grid

[JimMichael]

Description

During testing of 19.3.1 I just noticed multiple exceptions of the form

The value of the 'core.CustomGridColumnsConfig' attribute (id: 45843) on Rock.Model.Block id 7389 may not contain Lava formatting.

at Rock.Model.AttributeValue.SaveHook.PreSave() in \Rock\Model\Core\AttributeValue\AttributeValue.SaveHook.cs:line 41
at Rock.Data.DbContext.RockPreSave(DbContext dbContext, Nullable1 personAliasId, Boolean enableAuditing) in \\Rock\Data\DbContext.cs:line 571 at Rock.Data.DbContext.SaveChanges(SaveChangesArgs args) in \\Rock\Data\DbContext.cs:line 359 at Rock.Data.DbContext.SaveChanges(Boolean disablePrePostProcessing) in \\Rock\Data\DbContext.cs:line 323 at Rock.Attribute.Helper.SaveAttributeValues(IHasAttributes model, RockContext rockContext) in \\Rock\Attribute\Helper.cs:line 1890 at RockWeb.Blocks.Core.BlockProperties.<>c__DisplayClass36_0.<masterPage_OnSave>b__0() at Rock.Data.DbContext.<>c__DisplayClass34_0.<WrapTransaction>b__0() in \\Rock\Data\DbContext.cs:line 195 at Rock.Data.DbContext.WrapTransactionIf(Func1 action) in \Rock\Data\DbContext.cs:line 215
at Rock.Web.UI.DialogPage.FireSave(Object sender, EventArgs e) in \Rock\Web\UI\DialogPage.cs:line 99
at System.Web.UI.WebControls.LinkButton.OnClick(EventArgs e)
at System.Web.UI.WebControls.LinkButton.RaisePostBackEvent(String eventArgument)
at System.Web.UI.Page.d__523.MoveNext()
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
at System.Web.UI.Page.ProcessRequestMainAsync(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
at System.Web.UI.Page.d__515.MoveNext()
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
at System.Web.UI.Page.ProcessRequestAsync(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
at System.Web.UI.Page.<>c__DisplayClass554_0.b__0(Object _)
at System.Web.HttpContext.InvokeCancellableCallback(WaitCallback callback, Object state)
at System.Web.UI.Page.d__554.MoveNext()
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
at System.Web.UI.Page.ProcessRequestAsync(HttpContext context)
at System.Web.TaskAsyncHelper.BeginTask(Func`1 taskFunc, AsyncCallback callback, Object state)
at System.Web.HttpApplication.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute()
at System.Web.HttpApplication.ExecuteStepImpl(IExecutionStep step)
at System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)
at System.Web.HttpApplication.PipelineStepManager.ResumeSteps(Exception error)
at System.Web.HttpApplication.BeginProcessRequestNotification(HttpContext context, AsyncCallback cb)
at System.Web.HttpRuntime.ProcessRequestNotificationPrivate(IIS7WorkerRequest wr, HttpContext context)
at System.Web.Hosting.PipelineRuntime.ProcessRequestNotificationHelper(IntPtr rootedObjectsPointer, IntPtr nativeRequestContext, IntPtr moduleData, Int32 flags)
at System.Web.Hosting.PipelineRuntime.ProcessRequestNotification(IntPtr rootedObjectsPointer, IntPtr nativeRequestContext, IntPtr moduleData, Int32 flags)
at System.Web.Hosting.UnsafeIISMethods.MgdIndicateCompletion(IntPtr pHandler, RequestNotificationStatus& notificationStatus)
at System.Web.Hosting.UnsafeIISMethods.MgdIndicateCompletion(IntPtr pHandler, RequestNotificationStatus& notificationStatus)
at System.Web.Hosting.PipelineRuntime.ProcessRequestNotificationHelper(IntPtr rootedObjectsPointer, IntPtr nativeRequestContext, IntPtr moduleData, Int32 flags)
at System.Web.Hosting.PipelineRuntime.ProcessRequestNotification(IntPtr rootedObjectsPointer, IntPtr nativeRequestContext, IntPtr moduleData, Int32 flags)

Actual Behavior

Playing with custom grid columns on the Prayer Comments List Block WORKS (as in, the columns do render Lava), but it also throws exceptions.

Expected Behavior

No exceptions when adding/creating custom grid columns on this block

Steps to Reproduce

1. Edit a page with the Prayer Request List block
2. Add a custom column with Lava to the block, e.g. {{ Row.Id }}
3. Observe the exception in the log

Note that this also happens on the 19.3.2 fix we just installed

Issue Confirmation

• Perform a search on the Github Issues to see if your bug is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

19.3.1/19.3.2

Client Culture Setting

en-US

[JimMichael]

@cabal95 Are we gonna be chasing these down everwhere a custom grid gets touched, or was this truly isolated to the PR block?

[cabal95]

@JimMichael It was all blocks, but the fix should apply to every block that supports the "custom grid" settings. So you should not run into the same issue on other grid/list blocks once the commit is on your server.