Force check - #78
Merged
Merged
Conversation
Contributor
Author
|
Also merging this in time for the weekend CI runs. |
Contributor
Author
|
This was tested with the stackstorm-aws pack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix assignment of
FORCE_CHECK_ALL_FILESvariables, also do better at checking for empty and non-empty strings.And finally, fix the assignments to the
GIT_BRANCHandPYTHON_VERSIONvariables. TheGIT_BRANCHassignment was broken because it displayed all of the available branches (with the active branch first). And thePYTHON_VERSIONassignment was broken becausepython --versionprints the Python version to stderr, not stdout, soPYTHON_VERSIONwas always empty.