Ensure that the coverage module is installed if coverage is enabled - #4790
Merged
Conversation
pull-request-size
Bot
added
the
size/S
Kami
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pack CI Makefile runs the st2-run-pack-tests script install the coverage module if the coverage flag is passed.
Previously, if the script was run with the
-cand-jflags (with coverage and just run the tests), the script would skip the section that installs the coverage module. Luckily, nose is smart enough to still run tests without coverage, but when it reports that the coverage module isn't installed, it logs it as an error:This erroneous reporting can become a troubleshooting rabbit hole when pack CIs fail.
This PR ensures that at least the coverage module is installed if the
-c(run tests with coverage) flag is passed into the script, whether or not the-j(just tests) flag is passed in.