Configurable checkouts - #74
Merged
Merged
Conversation
blag
force-pushed
the
configurable-checkouts
branch
from
September 13, 2019 08:00
36dfc7d to
ff4f5b3
Compare
Kami
reviewed
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tweaks the
dependenciesscript to use environment variables to specify the branches of ST2 and lint-configs to checkout. I maintain reverse compatibility by using Bash magic (eg: variable references) to default to themasterbranch if the environment variables are not defined.This is useful for when you are working on fixing failing pack CIs and you want to test out some changes to, for instance, the
st2-run-pack-testsscript from the st2 repository. This should make it easier and faster to test out changes to the CI scripts for failing packs.Before this PR, you had to rerun a failed CircleCI workflow with SSH, SSH in, tweak the
dependenciesscript yourself (or manually checkout a different branch of st2 or lint-configs), and rerun the tests. With this PR, you just have to set environment variables in the CircleCI configuration and rerun the failed workflow.