Skip to content

Conversation

@ankurch627
Copy link
Contributor

@ankurch627 ankurch627 commented Sep 23, 2024

Purpose of this pull request

This pull request...

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

SUMO-243953

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Sep 23, 2024
@ankurch627 ankurch627 changed the title Doc changes Azure WebApps Draft: Doc changes Azure WebApps Sep 23, 2024
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankurch627, this PR adds a new file "azure-webapps.md" when file "webapps.md" already exists for Azure Web Apps. Instead of adding the new file, I suggest you edit the existing file.

@kimsauce kimsauce changed the title Draft: Doc changes Azure WebApps Doc changes - Azure WebApps Sep 23, 2024
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankurch627, I made some minor layout changes (see commit "Updates from review").

The dashboard images don't load in my local build. When I go to the URLs, it says "AccessDenied". Do you need to upload the images to S3 and make them public (like you needed to do for this PR)?

@kimsauce kimsauce self-requested a review September 30, 2024 17:28
@jpipkin1 jpipkin1 dismissed their stale review October 1, 2024 16:25

Dismissing review because I'm going on PTO Oct 2-12, 2024.

@jpipkin1
Copy link
Collaborator

jpipkin1 commented Oct 1, 2024

@kimsauce, the dashboard images still don't load for me (see comment above). Work with @ankurch627 to ensure the images work before publishing this PR.

@himanshu219
Copy link
Contributor

@kimsauce @jpipkin1 this one we can wait till tomorrow @ankurch627 is doing some changes and will reupload the screenshots

@kimsauce kimsauce enabled auto-merge October 2, 2024 18:58
@kimsauce kimsauce requested a review from jpipkin1 October 2, 2024 18:58
@kimsauce
Copy link
Collaborator

kimsauce commented Oct 2, 2024

Hi @ankurch627 , since the dashboard images have been delaying the release of another document (September apps recap), I've temporarily commented them out and merged the changes. I've opened a new ticket to address these dashboard images separately.

Thank you for your understanding!

@kimsauce kimsauce added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit d42dc92 Oct 2, 2024
@kimsauce kimsauce deleted the SUMO-243953 branch October 2, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants