Skip to content

SUMO-242752 | Changes in IIS otel app to add metric collection and dashboards #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 1, 2024
Merged

SUMO-242752 | Changes in IIS otel app to add metric collection and dashboards #4579

merged 6 commits into from
Oct 1, 2024

Conversation

@sumoanema
Copy link
Collaborator

@sumoanema sumoanema commented Sep 24, 2024 •
edited by jpipkin1
Loading

Changes in IIS otel app to add metric collection and dashboards.

Purpose of this pull request

This pull request...

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Sep 24, 2024
@sumoanema sumoanema added the do-not-merge Pull requests that should not be merged label Sep 25, 2024
@sumoanema sumoanema marked this pull request as ready for review September 25, 2024 06:49
JV0812
JV0812 reviewed Sep 25, 2024
View reviewed changes
@sumoanema sumoanema requested a review from JV0812 September 25, 2024 06:59
JV0812
JV0812 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kimsauce
kimsauce reviewed Sep 25, 2024
View reviewed changes
kimsauce
kimsauce reviewed Sep 25, 2024
View reviewed changes
@jpipkin1 jpipkin1 changed the title SUMO-242752 | Changes in IIS otel app to add metric collection and da… SUMO-242752 | Changes in IIS otel app to add metric collection and dashboards Sep 25, 2024
JV0812
JV0812 reviewed Sep 30, 2024
View reviewed changes
@sumoanema @kimsauce @JV0812
Apply suggestions from code review
ee42643 
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
@sumoanema sumoanema requested a review from JV0812 September 30, 2024 06:20
@JV0812 JV0812 mentioned this pull request Sep 30, 2024
Merged
4 tasks
@himanshu219 himanshu219 added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit e60eb45 Oct 1, 2024
@himanshu219 himanshu219 deleted the iisotel branch October 1, 2024 13:30
@kimsauce kimsauce mentioned this pull request Oct 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimsauce kimsauce kimsauce left review comments

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

Assignees

@sumoanema sumoanema

@JV0812 JV0812

Labels

cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sumoanema @kimsauce @jpipkin1 @JV0812 @himanshu219