Conversation
…ecks Remove unnecessary checks in middleware
Preserve ignores for coverage
Longer last attempt for Steamworks, return better error code
Fix player session race conditions
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Archiving feedback
Add feedback category resetting
Migrate from the scoped alpha packages to the consolidated stable release: - dinero.js: ^2.0.0-alpha.14 -> ^2.0.0 - @dinero.js/currencies -> dinero.js/currencies (subpath export) - Remove @dinero.js/currencies as a separate dependency
chore: upgrade dinero.js to v2.0.0 stable
Correctly calculate global value after stat reset
|
This is a well-structured release with good test coverage throughout. A couple of issues to address: 🟡 Potential Bugs
In feedback.deletedAt = archived ? new Date() : null
createGameActivity(em, { type: archived ? GAME_FEEDBACK_ARCHIVED : GAME_FEEDBACK_RESTORED, ... })Calling with Suggested fix: const currentlyArchived = feedback.deletedAt !== null
if (currentlyArchived === archived) {
return { status: 200, body: { feedback } }
}🔵 Minor IssuesTest typo ( it('should retry lock tineout exceptions', ...)
// ^ "tineout" should be "timeout"Test CoverageNo issues found — the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.