Skip to content

Conversation

@vraychev
Copy link

Up to date

@deepcodeappdev
Copy link

deepcodeappdev bot commented Oct 15, 2020

DeepCode's analysis on #384f90 found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
Use an array literal instead of the Array constructor. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

skabashnyuk and others added 29 commits November 23, 2020 16:21
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Fixes #18326 - Provides direct access to the kubernetes API on /api/unsupported/k8s.
Restricted to OpenShift with OpenShift OAuth.

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
* Replace 'server:start' with 'server:deploy' in E2E tests
* use '-k8spodwaittimeout' option when deploy Che
* Use '--k8spoddownloadimagetimeout' option when deploy Che

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
…_INTERNAL env. (#17945)

* Use internal network url for plugin, devfile registry and fix CHE_API_INTERNAL env.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
* Add ability to use internal network for keycloak.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Implement CA bundle propagation on Kubernetes infrastructures family

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
…86.0 (#18435)

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
* Allow replacing backslash in usernames during the first login

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
…pdated links to community PRs, use query (#18505)

Change-Id: I29c1febedf33206eac510a428e1db07810d68707
Signed-off-by: nickboldt <nboldt@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
…onfiguration (#18506)

* Added support for Keycloak admin secret
Added support to change endpoint-watcher image

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

* Added user feedback and validation for Keycloak password

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

* Apply suggestions from code review

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>

* Apply suggestions from code review

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Musienko Maksym <mmusiien@redhat.com>
* Added test failure duration logging

Signed-off-by: Tibor Dancs <tdancs@redhat.com>

* Increased run webapp task timeout

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
…ially visible) (#18486)

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
…ect import rejecting (#18531)


Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
…PACE_POD_NODE__SELECTOR in helm chart (#18528)

* Added support for Keycloak admin secret
Added support to change endpoint-watcher image

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

* Added user feedback and validation for Keycloak password

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

* Apply suggestions from code review

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>

* Apply suggestions from code review

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>

* Added nodeSelector feature to helm chart (was simply missing from chart)
Fixed the CHE_LIMITS_USER_WORKSPACES_RUN_COUNT name

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

* Fixed location of workspace.number field in values.yaml

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

* Apply suggestions from code review

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>

* Update deploy/kubernetes/helm/che/templates/configmap.yaml

Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>
…ting (#18410)

* Used images that moved from docker hub to quay for db integration testing

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
skabashnyuk and others added 28 commits May 1, 2021 16:43
* Removed SCM user name from git credential secret name

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: xbaran4 <pbaran@redhat.com>
… property

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Added missing unit for che.limits.workspace.idle.timeout che-server's property
Signed-off-by: svor <vsvydenk@redhat.com>
* Fixed no-string-literal linter rule

Signed-off-by: Tibor Dancs <tdancs@redhat.com>

* Refactored LsTests

Signed-off-by: Tibor Dancs <tdancs@redhat.com>

* Refactored CodeExecutionTests

Signed-off-by: Tibor Dancs <tdancs@redhat.com>

* Refactored ProjectAndFileTests

Signed-off-by: Tibor Dancs <tdancs@redhat.com>

* Refactored WorkspaceHandlingTests

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
* Remove workaround from 'GitSsh' E2E test
We don't use/test with singleuser for quite some time now.

Signed-off-by: Radim Hopp <rhopp@redhat.com>
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>

Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
* Upgrade dependencies

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
…19763)

* Remove code that supports namespace strategies other than per-user

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…Che 'single-host' (#19798)

* Update 'Happy-path' files to run E2E test on 'single-host'
* Do refactoring code
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
…orkspace Operator

(attributes being available at the root level)
devfile/devworkspace-operator#406

Change-Id: I5d8ee432aeaf62a9453cc23d443394776eb633ee
Signed-off-by: Florent Benoit <fbenoit@redhat.com>


Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@eclipsewebmaster eclipsewebmaster deleted the branch TestingCodeReview:master May 21, 2021 09:09
@eclipsewebmaster eclipsewebmaster deleted the master branch May 21, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.