Refine optional dimension drop for given attribute selection or matrix case (fixes #244)#245
Merged
eddelbuettel merged 3 commits intomasterfrom May 15, 2021
Merged
Refine optional dimension drop for given attribute selection or matrix case (fixes #244)#245eddelbuettel merged 3 commits intomasterfrom
eddelbuettel merged 3 commits intomasterfrom
Conversation
Shelnutt2
approved these changes
May 15, 2021
eddelbuettel
added a commit
that referenced
this pull request
May 16, 2021
eddelbuettel
added a commit
that referenced
this pull request
May 16, 2021
eddelbuettel
added a commit
that referenced
this pull request
May 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines when dimensions are dropped (or kept) when attributes are selected (and in the matrix case). Implicit use of the
extendedargument did not correctly cover all cases. The change addresses the issue ticket #244 filed by @LTLA last evening, and leads to two minor agument changes in tests.