Correct attribute type assignment for one-column attribute selection with row and col dimensions#246
Merged
eddelbuettel merged 3 commits intomasterfrom May 16, 2021
Merged
Conversation
Shelnutt2
approved these changes
May 16, 2021
Contributor
Author
|
Thanks. I put some more tests for this and previous PR in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug kindly reported vy @LTLA in this gist. In short, in the (common and key to his use) case of two (integer) dimensions and one (selected, or total) double attribute, when writing the data the buffer allocation used the wrong variable type. It was using the dimension type and not accounting for the attribute type. The change is simple and similar to what is done in other code paths. Some more detail is in CH 7493.