chore(id): retire legacy issuer defaults - #1480
Merged
Merged
Conversation
|
Warning Review limit reached
Next review available in: 22 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (20)
📝 WalkthroughWalkthroughThe change replaces the TokenDance ID issuer domain across deployment settings, application host handling, authorization fixtures, deep-link tests, OIDC tests, and login-readiness scenarios. ChangesTokenDance ID issuer domain
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DeliciousBuding
force-pushed
the
fix/id-domain-migration
branch
3 times, most recently
from
August 1, 2026 11:12
31b45fc to
5fac5e1
Compare
DeliciousBuding
force-pushed
the
fix/id-domain-migration
branch
from
August 1, 2026 17:30
5fac5e1 to
c36da38
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/contract/scripts/verify-token-dance-id-login-readiness.ps1 (1)
99-99: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse named parameters for every
New-DiscoveryFixturecall.The four calls depend on positional parameter order. Use
-Root,-Name, and-Jsonat each site.
tests/contract/scripts/verify-token-dance-id-login-readiness.ps1#L99-L99: name the blocked-discovery fixture arguments.tests/contract/scripts/verify-token-dance-id-login-readiness.ps1#L112-L112: name the invalid-discovery fixture arguments.tests/contract/scripts/verify-token-dance-id-login-readiness.ps1#L125-L125: name the secret-like-input fixture arguments.tests/contract/scripts/verify-token-dance-id-login-readiness.ps1#L138-L138: name the successful-readiness fixture arguments.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/contract/scripts/verify-token-dance-id-login-readiness.ps1` at line 99, Update every New-DiscoveryFixture call in tests/contract/scripts/verify-token-dance-id-login-readiness.ps1 to use named -Root, -Name, and -Json parameters: lines 99-99 for the blocked-discovery fixture, 112-112 for invalid-discovery, 125-125 for secret-like-input, and 138-138 for successful-readiness. Preserve each call’s existing argument values.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/contract/scripts/verify-token-dance-id-login-readiness.ps1`:
- Line 99: Update every New-DiscoveryFixture call in
tests/contract/scripts/verify-token-dance-id-login-readiness.ps1 to use named
-Root, -Name, and -Json parameters: lines 99-99 for the blocked-discovery
fixture, 112-112 for invalid-discovery, 125-125 for secret-like-input, and
138-138 for successful-readiness. Preserve each call’s existing argument values.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: dfc2fe28-62fb-4c71-b24d-dd401036c259
📒 Files selected for processing (21)
.env.exampleapp/desktop/scripts/manual-chat-flow-check.mjsapp/desktop/src/__e2e__/oidc-login.spec.tsapp/desktop/src/__e2e__/teamrun-ui-evidence.spec.tsapp/desktop/src/api/hubAuth.test.tsapp/mobile-rn/app.config.tsapp/mobile-rn/src/integrations/deepLinking.test.tsapp/shared/src/testing/e2eDataModeContract.test.tsapp/shared/src/testing/e2eDataModeContract.tsapp/web/scripts/manual-chat-flow-check.mjsapp/web/src/__e2e__/oidc-login.spec.tsdeployments/production/docker-compose.ymlhub-server/configs/config.yamlhub-server/deployments/.env.production.examplehub-server/deployments/docker-compose.prod.ymlhub-server/deployments/docker-compose.us1.ymlhub-server/deployments/hk2/.env.hk2.examplehub-server/deployments/hk2/docker-compose.hk2.ymlhub-server/internal/config/config_tokendance.gohub-server/tests/oidc/oidc_smoke_test.gotests/contract/scripts/verify-token-dance-id-login-readiness.ps1
added 3 commits
August 2, 2026 02:07
…list) check-secrets.sh only allowlists .env.example / .env.production.example paths; .env.hk2.example tripped the .env-style file rule on validate. The hk2 directory already distinguishes the file, so the rename keeps semantics identical.
check-secrets.sh flags any assignment whose variable name contains
"token" (e.g. AGENTHUB_TOKENDANCE_ID_ISSUER_URL) with a non-placeholder
value. Public endpoint URLs are configuration, not credentials — skip
*_URL assignments whose value contains :// (plain or ${VAR:-https://…}
default form). CLIENT_SECRET / *_TOKEN assignments are unaffected.
DeliciousBuding
force-pushed
the
fix/id-domain-migration
branch
from
August 1, 2026 18:07
3af6eb2 to
91b8bb4
Compare
DeliciousBuding
pushed a commit
that referenced
this pull request
Aug 1, 2026
…wave) - Hub integration fixtures: merged in #1489 - Edge tests on Linux: merged in #1491 (incl. ACP request-sequence race fix) - TokenDance ID defaults: merged in #1480 (+ check-secrets.sh *_URL exemption) - Frontend coverage gate: merged #1490 (web 63.14→66.72) / #1488 (desktop) - Edge lint debt: merged in #1491 (102→0, zero exclusions, .gitattributes eol) Remaining: CI policy parser (#1481), Doc SSOT compaction, Desktop typecheck, shared frontend tests.
DeliciousBuding
added a commit
that referenced
this pull request
Aug 1, 2026
…wave) (#1492) - Hub integration fixtures: merged in #1489 - Edge tests on Linux: merged in #1491 (incl. ACP request-sequence race fix) - TokenDance ID defaults: merged in #1480 (+ check-secrets.sh *_URL exemption) - Frontend coverage gate: merged #1490 (web 63.14→66.72) / #1488 (desktop) - Edge lint debt: merged in #1491 (102→0, zero exclusions, .gitattributes eol) Remaining: CI policy parser (#1481), Doc SSOT compaction, Desktop typecheck, shared frontend tests. Co-authored-by: Codex (Delicious233) <codex@vectorcontrol.tech>
This was referenced Aug 4, 2026
DeliciousBuding
added a commit
that referenced
this pull request
Aug 11, 2026
* chore(id): retire legacy issuer defaults
* chore(id): rename hk2 env example to .env.example (secret guard allowlist)
check-secrets.sh only allowlists .env.example / .env.production.example
paths; .env.hk2.example tripped the .env-style file rule on validate.
The hk2 directory already distinguishes the file, so the rename keeps
semantics identical.
* ci(verify): exempt *_URL endpoint assignments from secret-like scan
check-secrets.sh flags any assignment whose variable name contains
"token" (e.g. AGENTHUB_TOKENDANCE_ID_ISSUER_URL) with a non-placeholder
value. Public endpoint URLs are configuration, not credentials — skip
*_URL assignments whose value contains :// (plain or ${VAR:-https://…}
default form). CLIENT_SECRET / *_TOKEN assignments are unaffected.
* docs(id): update hk2 env example copy instructions to renamed file
---------
Co-authored-by: Codex <codex@vectorcontrol.tech>
DeliciousBuding
added a commit
that referenced
this pull request
Aug 11, 2026
…wave) (#1492) - Hub integration fixtures: merged in #1489 - Edge tests on Linux: merged in #1491 (incl. ACP request-sequence race fix) - TokenDance ID defaults: merged in #1480 (+ check-secrets.sh *_URL exemption) - Frontend coverage gate: merged #1490 (web 63.14→66.72) / #1488 (desktop) - Edge lint debt: merged in #1491 (102→0, zero exclusions, .gitattributes eol) Remaining: CI policy parser (#1481), Doc SSOT compaction, Desktop typecheck, shared frontend tests. Co-authored-by: Codex <codex@vectorcontrol.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces active AgentHub defaults, examples, deployment templates, and fixture contracts with the sole TokenDance ID issuer id.tokendancelab.com. The retired id.vectorcontrol.tech hostname is not kept as a redirect or alias. Validation: full hub-server short suite passed; readiness contract passed; focused Desktop, Shared, and Mobile tests passed (28 tests). Evidence level is backend-api plus fixture-unit/readiness; no approved-real login was performed. PowerShell governance gates passed. Base master currently has unrelated coverage/typecheck/mobile-boundary failures; the secret guard also false-positives on issuer URL lines because variable names contain TOKEN and on the tracked .env.hk2.example path; staged added lines were manually verified to contain URLs/placeholders only.
Summary by CodeRabbit
Configuration
id.tokendancelab.comissuer across supported applications and deployment environments.Authentication
Tests