Skip to content

test(web): restore coverage baseline above gate (63.14 -> 66.72 lines) - #1490

Merged
DeliciousBuding merged 1 commit into
masterfrom
test/coverage-baseline-recovery
Aug 1, 2026
Merged

test(web): restore coverage baseline above gate (63.14 -> 66.72 lines)#1490
DeliciousBuding merged 1 commit into
masterfrom
test/coverage-baseline-recovery

Conversation

@DeliciousBuding

Copy link
Copy Markdown
Collaborator

背景

validate job 的 coverage baseline gate 挂:agenthub-web 与 agenthub-desktop 全指标回归(web lines 63.14 < 63.61 等)。

修复内容

web(3 文件,+304 行测试)

  • executionTargetQueries.test.ts / hubAuth.test.ts:扩展 API 层测试
  • toastStore.test.ts(新增):覆盖 addToast/showToast/dismissToast/removeToast + 自动消失/上限 5/不可变

desktop(3 文件,新增)

  • hubAuth.contract.test.ts / useAuth.test.ts / useDesktopCommands.behavior.test.ts

结果(本地 vitest --coverage)

指标 修复前 修复后 baseline
web lines 63.14 66.72 63.61
web statements 61.93 65.61 62.19
web functions 52.11 55.72 53.42
web branches 58.82 60.26 59.48

全部指标 ≥ baseline(未降低任何阈值),desktop 同组测试也超过其 baseline。

验证

web + desktop 测试全过(1737 passed, 0 failed, 0 skipped)。

Copilot AI review requested due to automatic review settings August 1, 2026 16:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DeliciousBuding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 11192109-190c-4e41-ab10-29d9cb1d6706

📥 Commits

Reviewing files that changed from the base of the PR and between 1d2feff and 260e24f.

📒 Files selected for processing (7)
  • .gitignore
  • app/desktop/src/api/hubAuth.contract.test.ts
  • app/desktop/src/hooks/useAuth.test.ts
  • app/desktop/src/hooks/useDesktopCommands.behavior.test.ts
  • app/web/src/api/executionTargetQueries.test.ts
  • app/web/src/api/hubAuth.test.ts
  • app/web/src/stores/toastStore.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

web: extend executionTargetQueries/hubAuth API tests, add toastStore tests
(lines 66.72, statements 65.61, functions 55.72, branches 60.26 — all
above coverage-baseline.json; the functions metric was the last one
below baseline at 53.21 vs 53.42).

desktop: add hubAuth contract, useAuth, useDesktopCommands behavior tests
(also above their baseline metrics).

Also ignore vitest test-results.json output next to test-results/.
@DeliciousBuding
DeliciousBuding force-pushed the test/coverage-baseline-recovery branch from 8b095e2 to 260e24f Compare August 1, 2026 16:26
@DeliciousBuding
DeliciousBuding merged commit ed888f9 into master Aug 1, 2026
21 checks passed
@DeliciousBuding
DeliciousBuding deleted the test/coverage-baseline-recovery branch August 1, 2026 16:42
DeliciousBuding pushed a commit that referenced this pull request Aug 1, 2026
…wave)

- Hub integration fixtures: merged in #1489
- Edge tests on Linux: merged in #1491 (incl. ACP request-sequence race fix)
- TokenDance ID defaults: merged in #1480 (+ check-secrets.sh *_URL exemption)
- Frontend coverage gate: merged #1490 (web 63.14→66.72) / #1488 (desktop)
- Edge lint debt: merged in #1491 (102→0, zero exclusions, .gitattributes eol)

Remaining: CI policy parser (#1481), Doc SSOT compaction, Desktop typecheck,
shared frontend tests.
DeliciousBuding added a commit that referenced this pull request Aug 1, 2026
…wave) (#1492)

- Hub integration fixtures: merged in #1489
- Edge tests on Linux: merged in #1491 (incl. ACP request-sequence race fix)
- TokenDance ID defaults: merged in #1480 (+ check-secrets.sh *_URL exemption)
- Frontend coverage gate: merged #1490 (web 63.14→66.72) / #1488 (desktop)
- Edge lint debt: merged in #1491 (102→0, zero exclusions, .gitattributes eol)

Remaining: CI policy parser (#1481), Doc SSOT compaction, Desktop typecheck,
shared frontend tests.

Co-authored-by: Codex (Delicious233) <codex@vectorcontrol.tech>
DeliciousBuding added a commit that referenced this pull request Aug 11, 2026
#1490)

web: extend executionTargetQueries/hubAuth API tests, add toastStore tests
(lines 66.72, statements 65.61, functions 55.72, branches 60.26 — all
above coverage-baseline.json; the functions metric was the last one
below baseline at 53.21 vs 53.42).

desktop: add hubAuth contract, useAuth, useDesktopCommands behavior tests
(also above their baseline metrics).

Also ignore vitest test-results.json output next to test-results/.

Co-authored-by: Codex <codex@vectorcontrol.tech>
DeliciousBuding added a commit that referenced this pull request Aug 11, 2026
…wave) (#1492)

- Hub integration fixtures: merged in #1489
- Edge tests on Linux: merged in #1491 (incl. ACP request-sequence race fix)
- TokenDance ID defaults: merged in #1480 (+ check-secrets.sh *_URL exemption)
- Frontend coverage gate: merged #1490 (web 63.14→66.72) / #1488 (desktop)
- Edge lint debt: merged in #1491 (102→0, zero exclusions, .gitattributes eol)

Remaining: CI policy parser (#1481), Doc SSOT compaction, Desktop typecheck,
shared frontend tests.

Co-authored-by: Codex <codex@vectorcontrol.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants