docs(progress): mark main-branch recovery items resolved (2026-08-02 wave) - #1492
Conversation
📝 WalkthroughWalkthroughUpdated ChangesRecovery Status Documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…wave) - Hub integration fixtures: merged in #1489 - Edge tests on Linux: merged in #1491 (incl. ACP request-sequence race fix) - TokenDance ID defaults: merged in #1480 (+ check-secrets.sh *_URL exemption) - Frontend coverage gate: merged #1490 (web 63.14→66.72) / #1488 (desktop) - Edge lint debt: merged in #1491 (102→0, zero exclusions, .gitattributes eol) Remaining: CI policy parser (#1481), Doc SSOT compaction, Desktop typecheck, shared frontend tests.
02a38ed to
24a764e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/progress/MASTER.md`:
- Around line 19-23: Update the resolved-date labels in the affected MASTER.md
progress rows to use the actual pull-request merge/completion dates, replacing
the currently shown 2026-08-02 values with 2026-08-01 where applicable. Update
the document’s “Last updated” value to match the latest corrected merge date,
while preserving the existing row descriptions and PR references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 29bd601a-1ae2-4575-8943-1dd297c8cf7d
📒 Files selected for processing (1)
docs/progress/MASTER.md
| | ~~Edge tests on Linux~~ | **RESOLVED 2026-08-02** — backup permission-mode test portability (#1491's CI sweep verified); ACP request-sequence race fixed by recording the method before answering (`acp_client_test.go`) | merged in #1491 | | ||
| | ~~Hub integration~~ | **RESOLVED 2026-08-02** — errcode lowercase contract, admin fixture (AGENTHUB_ADMIN_USERS), OIDC config injection, refresh_token FK device seeding, OIDC E2E UUID/scopes/shared-cache SQLite, TeamRun guardrail messages, execution-target ping projection | merged in #1489 | | ||
| | ~~TokenDance ID defaults~~ | **RESOLVED 2026-08-02** — issuer default switched to id.tokendancelab.com; check-secrets.sh now exempts `*_URL` endpoint assignments (TOKENDANCE name contains "token" → false positive) | merged in #1480 | | ||
| | ~~Frontend coverage gate~~ | **RESOLVED 2026-08-02** — web 63.14→66.72 lines (executionTargetQueries/hubAuth/toastStore tests, #1490); desktop tests (#1488); master CI green on 36a24a4b | merged #1490/#1488 | | ||
| | ~~Edge lint debt~~ | **RESOLVED 2026-08-02** — 102→0 golangci-lint issues via pure extraction refactors (RegisterRoutes 69→14 sub-functions, PostRuns 123→~12, parseSSEStream 74→state+handlers…); zero .golangci.yml exclusions; `*.go text eol=lf` in .gitattributes fixes Windows CRLF gofmt churn | merged in #1491 | |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
for pr in 1489 1491 1480 1490 1488; do
gh pr view "$pr" --json number,state,mergedAt,mergeCommit \
--jq '{number,state,mergedAt,mergeCommit}'
done
git show --no-patch --format='%H %cI' 36a24a4bRepository: TokenDanceLab/AgentHub
Length of output: 887
Replace the 2026-08-02 resolved statuses with actual merge dates.
The referenced pull requests merged on 2026-08-01, and the commit evidence timestamp is the author commit time, not the resolution date. Update these rows to the actual merge/completion dates and align Last updated accordingly.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/progress/MASTER.md` around lines 19 - 23, Update the resolved-date
labels in the affected MASTER.md progress rows to use the actual pull-request
merge/completion dates, replacing the currently shown 2026-08-02 values with
2026-08-01 where applicable. Update the document’s “Last updated” value to match
the latest corrected merge date, while preserving the existing row descriptions
and PR references.
…wave) (#1492) - Hub integration fixtures: merged in #1489 - Edge tests on Linux: merged in #1491 (incl. ACP request-sequence race fix) - TokenDance ID defaults: merged in #1480 (+ check-secrets.sh *_URL exemption) - Frontend coverage gate: merged #1490 (web 63.14→66.72) / #1488 (desktop) - Edge lint debt: merged in #1491 (102→0, zero exclusions, .gitattributes eol) Remaining: CI policy parser (#1481), Doc SSOT compaction, Desktop typecheck, shared frontend tests. Co-authored-by: Codex <codex@vectorcontrol.tech>
更新 docs/progress/MASTER.md 的 Main branch recovery 表:本轮(2026-08-02)已解决的红色信号标记为 RESOLVED 并附合并 PR 引用。
*_URL端点豁免修复误报)剩余项保留:CI policy parser(#1481)、Doc SSOT 收敛、Desktop typecheck、shared frontend tests。
Summary by CodeRabbit