Skip to content

Added click tracking columns to automated_email_recipients#29498

Closed
EvanHahn wants to merge 3 commits into
mainfrom
evanhahn-ny-1487-add-track_clicks-and-clicked_at-to
Closed

Added click tracking columns to automated_email_recipients#29498
EvanHahn wants to merge 3 commits into
mainfrom
evanhahn-ny-1487-add-track_clicks-and-clicked_at-to

Conversation

@EvanHahn

Copy link
Copy Markdown
Contributor

closes https://linear.app/ghost/issue/NY-1487

These are very similar to opened_at and track_opens, but for clicks.

closes https://linear.app/ghost/issue/NY-1487

These are very similar to `opened_at` and `track_opens`, but for clicks.
@github-actions github-actions Bot added the migration [pull request] Includes migration for review label Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • ⚠️ Tested performance on staging database servers, as performance on local machines is not comparable to a production environment
  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 98d2bcf4-1326-4f4e-b2c7-beada3961098

📥 Commits

Reviewing files that changed from the base of the PR and between 04fff3e and ecfe399.

📒 Files selected for processing (3)
  • ghost/core/core/server/data/migrations/versions/6.54/2026-07-21-17-35-30-add-click-tracking-to-automated-email-recipients.js
  • ghost/core/core/server/data/schema/schema.js
  • ghost/core/test/unit/server/data/schema/integrity.test.js

Walkthrough

Adds nullable clicked_at and defaulted track_clicks fields to automated_email_recipients through a non-transactional migration. Updates the database schema declaration and adjusts the schema integrity test to expect the resulting hash.

Suggested reviewers: cmraible, rob-ghost

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding click-tracking columns to automated_email_recipients.
Description check ✅ Passed The description is directly related to the change, noting click-tracking fields similar to opened_at and track_opens.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch evanhahn-ny-1487-add-track_clicks-and-clicked_at-to

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 21, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 1b485cc

Command Status Duration Result
nx run ghost:test:integration ❌ Failed 2m 26s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 50s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 8s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 19s View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 32s View ↗
nx run-many -t lint -p ghost,ghost-monorepo ✅ Succeeded 21s View ↗
nx run @tryghost/admin:build ✅ Succeeded 8s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗

💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.


☁️ Nx Cloud last updated this comment at 2026-07-21 20:22:35 UTC

@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 29853814397 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 29854871191 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 29864971585 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@troyciesco

Copy link
Copy Markdown
Contributor

closing in favor of #29529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration [pull request] Includes migration for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants