Added `track_clicks` and `clicked_at` columns to `automated_email_recipients` table by cmraible · Pull Request #29529 · TryGhost/Ghost

cmraible · 2026-07-22T14:00:04Z

closes https://linear.app/ghost/issue/NY-1487/

Summary

Added track_clicks and clicked_at columns to automated email recipients
Updated the current schema definition and integrity hash

coderabbitai · 2026-07-22T14:00:16Z

Walkthrough

Adds track_clicks and clicked_at to automated_email_recipients through a migration and schema update. Recipient creation paths initialize click tracking as disabled. Schema integrity and repository tests include the new columns and expected default values.

Possibly related PRs

TryGhost/Ghost#29399: Modifies the same recipient-recording flow and its in-memory schema.
TryGhost/Ghost#29460: Changes transactional ordering in the same recordEmailSent code path.
TryGhost/Ghost#29498: Overlaps with the click-tracking migration and schema updates.

Suggested reviewers: evanhahn

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the main schema change to automated_email_recipients.
Description check	✅ Passed	The description is directly related to the schema update and integrity hash change.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chris-ny-1487-add-track_clicks-and-clicked_at-to

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-22T14:00:19Z

nx-cloud · 2026-07-22T14:01:19Z

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci

View your CI Pipeline Execution ↗ for commit 5f8108b

Command	Status	Duration	Result
`nx run ghost:test:ci:integration`	✅ Succeeded	2m 17s	View ↗
`nx run ghost:test:legacy`	✅ Succeeded	1m 50s	View ↗
`nx run ghost:test:integration`	✅ Succeeded	3m 20s	View ↗
`nx run ghost-monorepo:lint:boundaries`	✅ Succeeded	21s	View ↗
`nx run-many -t lint -p ghost,ghost-monorepo`	✅ Succeeded	20s	View ↗
`nx run-many -t test:unit -p ghost`	✅ Succeeded	30s	View ↗
`nx run ghost:test:e2e`	✅ Succeeded	2m 47s	View ↗
`nx run @tryghost/admin:build`	✅ Succeeded	9s	View ↗
`nx run-many --target=build --projects=tag:publi...`	✅ Succeeded	<1s	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-07-22 15:32:45 UTC

github-actions · 2026-07-22T14:12:06Z

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 29926481869 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

cmraible · 2026-07-22T14:36:05Z

@@ -242,6 +242,8 @@ export function createDatabaseAutomationsRepository({
                    automation_action_revision_id: options.automationActionRevisionId,
                    ...(options.mailgunMessageId ? {mailgun_message_id: options.mailgunMessageId} : {}),
                    track_opens: options.trackOpens,
+                    // TODO(NY-1491) Snapshot the email_track_clicks setting when creating recipients.
+                    track_clicks: false,


note: bookshelf passes track_clicks: null if we omit this, so we have to explicitly pass track_clicks: false or this migration will effectively break migrations.

cmraible · 2026-07-22T14:36:24Z

@@ -235,7 +235,8 @@ async function processRun({
                member_uuid: member.get('uuid'),
                member_email: member.get('email'),
                member_name: member.get('name'),
-                track_opens: false
+                track_opens: false,
+                track_clicks: false


note: same as above, but this will always remain false since we don't care about click tracking for welcome emails.

cmraible · 2026-07-22T14:58:46Z

@CodeRabbit review

coderabbitai · 2026-07-22T14:58:55Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ghost/core/core/server/services/automations/database-automations-repository.ts`:
- Around line 245-246: Update recordEmailSent and its callers to thread the
automation’s email_track_clicks setting through options, then assign that value
to track_clicks when creating regular automation recipients instead of
hardcoding false. Preserve the welcome-email path’s explicitly disabled tracking
behavior if it is intentionally separate.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 051dedd5-9384-4a05-a82a-96193ebd7c1e

📥 Commits

Reviewing files that changed from the base of the PR and between e91932a and fad725f.

📒 Files selected for processing (6)

ghost/core/core/server/data/migrations/versions/6.54/2026-07-22-10-41-08-add-click-tracking-to-automated-email-recipients.js
ghost/core/core/server/data/schema/schema.js
ghost/core/core/server/services/automations/database-automations-repository.ts
ghost/core/core/server/services/automations/welcome-email-automation-poll.js
ghost/core/test/unit/server/data/schema/integrity.test.js
ghost/core/test/unit/server/services/automations/automations-repository.test.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fad725f0e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ref https://linear.app/ghost/issue/NY-1487/ Automation sends need to retain the click-tracking setting and first-click timestamp alongside the existing open analytics fields.

cmraible · 2026-07-22T15:30:02Z

CI seems a bit backed up, but this should pass.

github-actions Bot added the migration [pull request] Includes migration for review label Jul 22, 2026

cmraible force-pushed the chris-ny-1487-add-track_clicks-and-clicked_at-to branch from fe9bfc5 to c7b7ced Compare July 22, 2026 14:27

cmraible commented Jul 22, 2026

View reviewed changes

cmraible force-pushed the chris-ny-1487-add-track_clicks-and-clicked_at-to branch 2 times, most recently from 640fae5 to fad725f Compare July 22, 2026 14:45

cmraible marked this pull request as ready for review July 22, 2026 14:59

coderabbitai Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread ghost/core/core/server/services/automations/database-automations-repository.ts

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread ...ations/versions/6.54/2026-07-22-10-41-08-add-click-tracking-to-automated-email-recipients.js Outdated

NY-1487 - Added recipient click-tracking migration

5f8108b

ref https://linear.app/ghost/issue/NY-1487/ Automation sends need to retain the click-tracking setting and first-click timestamp alongside the existing open analytics fields.

cmraible force-pushed the chris-ny-1487-add-track_clicks-and-clicked_at-to branch from fad725f to 5f8108b Compare July 22, 2026 15:15

cmraible changed the title ~~Added recipient click-tracking migration~~ Added track_clicks and clicked_at columns to automated_email_recipients table Jul 22, 2026

cmraible requested a review from EvanHahn July 22, 2026 15:29

cmraible mentioned this pull request Jul 22, 2026

Added email_clicked_count column to automation_action_revisions table #29532

Merged

cmraible added the ok to merge for me You can merge this on my behalf if you want. label Jul 22, 2026

cmraible requested review from troyciesco and removed request for EvanHahn July 22, 2026 15:55

troyciesco approved these changes Jul 22, 2026

View reviewed changes

troyciesco merged commit 49d24c7 into main Jul 22, 2026
50 checks passed

troyciesco deleted the chris-ny-1487-add-track_clicks-and-clicked_at-to branch July 22, 2026 16:35

troyciesco mentioned this pull request Jul 22, 2026

Added click tracking columns to automated_email_recipients #29498

Closed

coderabbitai Bot mentioned this pull request Jul 23, 2026

Populated track_clicks when sending an automated email #29544

Merged

Uh oh!

Uh oh!

Conversation

cmraible commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited by cmraible Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

General requirements

Schema changes

Data changes

Uh oh!

nx-cloud Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Nx Cloud AI Fix

Uh oh!

github-actions Bot commented Jul 22, 2026

E2E Tests Failed

Uh oh!

cmraible Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

cmraible Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

cmraible commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cmraible commented Jul 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cmraible commented Jul 22, 2026 •

edited

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited by cmraible

Loading

nx-cloud Bot commented Jul 22, 2026 •

edited

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading