Conversation
…place it with a parameter, the value for which is estimated based on the proportion of times the condition was treated under the previous logic
…e behaviour that intended originally (per the write-up)
…ration to deaths for acute events (heart attack, stroke)
BinglingICL
approved these changes
Jun 9, 2023
Collaborator
BinglingICL
left a comment
BinglingICL
left a comment
There was a problem hiding this comment.
Thanks very much @tbhallett. All looks great to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main chnage is replacing the logic in the CardioMetabolicDisorders Module whereby treatment was only provided if the squeeze_factor was low (
< 0.5). It appears that this check would only rarely have permitted treatment to be provided in the fully running model, despite the document and the scripts for calibration expecting these appointments "mostly" to occur ("mostly" in the document, and "all" in the analysis scripts).I have tried values for this parameter of 0.1, 0.5 and 0.9 (see attached file) and conclude that a value of 0.5 is most consistent with the estimate number of deaths.
Other changes
ChronicSyndromeDepressionCDM issue.pptx