Hdrp/update decal handles pivot #3001

RSlysz · 2021-01-06T16:39:02Z

Purpose of this PR

This PR add the missing customizable pivot to Decals. It is required for placement snapping and finely tuning rotation point.
This contains the following changes:

Add Pivot in the inspector. Modifying it will decal the projection box from the transform point.
Add pivot and UV edit mode. In this mode, you can modify the pivot without moving the box position. It will automatically adapt transform position for the box to remain still.
Add customizable shortcut key for this new edit mode.
Add customizable color for the Decal's Gizmo / Handle. The main point here is to be able to select different intensity which is really useful when dealing with dark environment/ really bright environment.

This also fix:

Testing status

Tested the handles of previous edit mode and new edit mode with

pivot not at (0,0,0)
transform not at position (0,0,0)
transform with a random rotation
size different than (1,1) and projection depth different than 1
In all above cases, it seams to behave correctly.

Tested that changing the Transform's rotation make the projection volume rotate around the pivot as intended.

Tested color and face intensity change along the color set in the preference.

Tested Undo/Redo on edition by handle of the pivot point (with new edit mode)

Comments to reviewers

ColorPref are internal and cannot be directly used. I kinda hacked it by using them with reflection and Activator. It is not a nice integration but it seams to work. Particularly because the color list seams to be updated each time the window is enabled. So AFAIK what I have done should work fine.

Also, the default color provided to the ColorPref is the same than now. So this should not change on users at update without them actively modifying it.

To do this I had to tweek a little the HierarchicalBox used also for DensityVolume and ReflectionProbe's gizmo/handle. The change is minor and should not affect the behaviour of those.

All modification are only on the Editor manipulation side. So there is no actual change of the projection volume computation code. Which means that there is no need to migrate any data, they should still work fine. Though a test on that could be nice to be 100% sure.

@SeanPuller for awareness

@qa After discussion with @MaddalenaUnity , the color is not under HDRP but under Scene

com.unity.render-pipelines.core/Editor/Gizmo/HierarchicalBox.cs

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DecalProjectorEditor.cs

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DisplacableRectHandles.cs

com.unity.render-pipelines.high-definition/Editor/Material/Decal/ProjectedTransform.cs

SeanPuller · 2021-01-07T09:45:13Z

Bug with modifying Z Projection depth and resetting Z pivot
https://user-images.githubusercontent.com/43151199/103877398-4f158a80-50d5-11eb-845a-428a8f7aedb4.mp4

For better placment with prefabs

RSlysz · 2021-01-08T09:26:39Z

Last commits are feedbacks from @SeanPuller . He will do another pass soon.
So for reviewers, I'll tell you when code will be stable.
And meanwhile I'll add the missing documentation.

RSlysz · 2021-01-11T08:58:58Z

Ok no more change beside the documentation.

Remaining work (keeping ratio when scaling) will be in another PR for clarity.

JordanL8 · 2021-01-11T16:03:13Z

com.unity.render-pipelines.high-definition/Documentation~/Decal-Projector.md

-|![](Images/DecalProjector4.png)|**Crop**|Crops the decal with the projector box. This changes the size of the projector box but not the UVs of the Material. This crops the decal.|
+|![](Images/DecalProjector3.png)|**Scale**|Scales the decal with the projector box. This changes the UVs of the Material to match the size of the projector box. This stretches the decal. The Pivot remains still.|
+|![](Images/DecalProjector4.png)|**Crop**|Crops the decal with the projector box. This changes the size of the projector box but not the UVs of the Material. This crops the decal. The Pivot remains still.|
+|![](Images/DecalProjector5.png)|**Pivot / UV**|Move the pivot without moving the projection box. This alter the transform position.<br />Also, set the UV used on the projected texture.|


Moves the decal's pivot point without moving the projection box. This changes the transform position.
Note this also sets the UV used on the projected texture.

JordanL8 · 2021-01-11T16:05:04Z

com.unity.render-pipelines.high-definition/Documentation~/Decal-Projector.md

 | ----------------------- | ------------------------------------------------------------ |
 | **Size**                | The size of the projector influence box, and thus the decal along the projected plane. The projector scales the decal to match the **Width** (along the local x-axis) and **Height** (along the local y-axis) components of the **Size**. |
 | **Projection Depth**    | The depth of the projector influence box. The projector scales the decal to match **Projection Depth**. The Decal Projector component projects decals along the local z-axis. |
+| **Pivot**               | The offset position of the transform regarding the projection box. Adjusting X and Y allows to make rotation of the projected texture around a specific position, while Z allows to have a specific offset in depth. |


The offset position of the transform regarding the projection box. To rotate the projected texture around a specific position, adjust the X and Y values. To set a depth offset for the projected texture, adjust the Z value.

JordanL8 · 2021-01-11T16:06:04Z

com.unity.render-pipelines.high-definition/Documentation~/Decal-Projector.md

 * A box that describes the 3D size of the projector; the projector draws its decal on every Material inside the box.

-* An arrow that indicates the direction the projector faces.
+* An arrow that indicates the direction the projector faces. This arrow is on the pivot point.


The base of this arrow is on the pivot point.

^^
Assumed its the base, ignore this comment if it isn't

alex-vazquez

Good code overall :). I found minor things that I think you should double check before merging.

alex-vazquez · 2021-01-18T14:06:03Z

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DisplacableRectHandles.cs

+        }
+
+        /// <summary>Draw the rect.</summary>
+        public void DrawRect(bool dottedLine = false, float sickness = .0f, float screenSpaceSize = 5f)


I think you meant thickness instead of sickness ?

alex-vazquez · 2021-01-18T15:35:53Z

com.unity.render-pipelines.core/Editor/Gizmo/HierarchicalBox.cs

+        {
+            m_MonochromeFillColor = color;
+            material.color = m_MonochromeFillColor;
+            color.a = 1f;


In DisplacableRectHandles.baseColor we also have the same alpha values, can have them declared somewhere? Just in case we want to change them will be equal in both places. Maybe a static function SetAlphaHandleValues()?

alex-vazquez · 2021-01-18T15:45:31Z

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DisplacableRectHandles.cs

+                        {
+                            if (min[axis] > max[axis])
+                            {
+                                // Control IDs in m_ControlIDs[0-3[ are for positive axes


Typo on the comment: [0-3]

alex-vazquez · 2021-01-18T15:48:45Z

com.unity.render-pipelines.high-definition/Editor/Material/Decal/ProjectedTransform.cs

+                if (!(obj is PositionHandleIds))
+                    return false;
+
+                var o = (PositionHandleIds)obj;


You can avoid this second cast if you do:

if (!(obj is PositionHandleIds o)) return false;

alex-vazquez · 2021-01-18T16:01:13Z

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DecalProjectorEditor.cs

+                // UV
+                using (new Handles.DrawingScope(Matrix4x4.TRS(decalProjector.transform.position + decalProjector.transform.rotation * (decalProjector.offset - .5f * decalProjector.size), decalProjector.transform.rotation, Vector3.one)))
+                {
+                    Vector2 UVSize = new Vector2(


You should name it uvSize as it is a local variable

alex-vazquez · 2021-01-19T10:01:48Z

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DisplacableRectHandles.cs

+                        switch (theChangedEdge)
+                        {
+                            case NamedEdge.Left:
+                                if (rightPosition.x < leftPosition.x)
+                                    leftPosition.x = rightPosition.x;
+                                if (topPosition.y < bottomPosition.y)
+                                    topPosition.y = bottomPosition.y = center.y;
+                                break;
+                            case NamedEdge.Right:
+                                if (rightPosition.x < leftPosition.x)
+                                    rightPosition.x = leftPosition.x;
+                                if (topPosition.y < bottomPosition.y)
+                                    topPosition.y = bottomPosition.y = center.y;
+                                break;
+                            case NamedEdge.Top:
+                                if (topPosition.y < bottomPosition.y)
+                                    topPosition.y = bottomPosition.y;
+                                if (rightPosition.x < leftPosition.x)
+                                    rightPosition.x = leftPosition.x = center.x;
+                                break;
+                            case NamedEdge.Bottom:
+                                if (topPosition.y < bottomPosition.y)
+                                    bottomPosition.y = topPosition.y;
+                                if (rightPosition.x < leftPosition.x)
+                                    rightPosition.x = leftPosition.x = center.x;
+                                break;
+                        }


Same here, another method will improve readability

EnsureEdgesFacingOutside();

alex-vazquez · 2021-01-19T10:22:28Z

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DecalProjectorEditor.cs

 using UnityEngine;
-using UnityEngine.Rendering;
 using UnityEngine.Rendering.HighDefinition;
 using UnityEditor.ShortcutManagement;
 using static UnityEditorInternal.EditMode;
+using UnityEditor.IMGUI.Controls;
+using System;
+using System.Collections.Generic;
+using System.Reflection;
+using System.Linq.Expressions;


Can you sort usings statements?

alex-vazquez · 2021-01-19T10:28:52Z

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DecalProjectorEditor.cs

+                }
+                else
+                {
+                    Quaternion arrowRotation = Quaternion.LookRotation(Vector3.down, Vector3.right);


Where are you using arrowRotation? I can not see it.

alex-vazquez · 2021-01-19T11:54:43Z

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DecalProjectorEditor.cs

+            // PrefColor is the type to use to have a Color that is customizable inside the Preference/Colors panel.
+            // Sadly it is internal so we must create it and grab color from it by reflection.
+            Type prefColorType = typeof(Editor).Assembly.GetType("UnityEditor.PrefColor");
+            s_ColorPref = Activator.CreateInstance(prefColorType, new object[] { "HDRP/Decal", k_GizmoColorBase.r, k_GizmoColorBase.g, k_GizmoColorBase.b, k_GizmoColorBase.a });


I think @MaddalenaUnity wants to unify the colors under Rendering, could you double check?

alex-vazquez · 2021-01-19T11:56:01Z

com.unity.render-pipelines.high-definition/Editor/Material/Decal/DecalProjectorEditor.cs

+                // Pivot
+                using (new Handles.DrawingScope(fullColor, Matrix4x4.TRS(Vector3.zero, decalProjector.transform.rotation, Vector3.one)))
+                {
+                    EditorGUI.BeginChangeCheck();
+                    Vector3 newPosition = ProjectedTransform.DrawHandles(decalProjector.transform.position, .5f * decalProjector.size.z - decalProjector.offset.z, decalProjector.transform.rotation);
+                    if (EditorGUI.EndChangeCheck())
                    {
-                        needToRefreshDecalProjector = true;
+                        Undo.RecordObjects(new UnityEngine.Object[] { decalProjector, decalProjector.transform }, "Decal Projector Change");

-                        // Both the DecalProjectorComponent, and the transform will be modified.
-                        // The undo system will automatically group all RecordObject() calls here into a single action.
-                        Undo.RecordObject(decalProjector.transform, "Decal Projector Change");
+                        decalProjector.offset += Quaternion.Inverse(decalProjector.transform.rotation) * (decalProjector.transform.position - newPosition);
+                        decalProjector.transform.position = newPosition;
+                    }
+                }


Instead of //Pivot, I think it will be clearer if you add it's own method. this also applies to //UV

alex-vazquez

Good improvements, thank you :)

RSlysz · 2021-01-21T11:33:34Z

@TomasKiniulis Above commit add missing public API to change pivot by script. Also add an helper to resize and use the pivot as center of the transformation.

RSlysz · 2021-01-22T10:22:09Z

@TomasKiniulis > Add requested fallback when we switch edit mode and UV/Pivot is selected, we fallback on first edit mode now.

TomasKiniulis

Verified the bugfixes and checked through the changes. Pivot and UV adjustment gizmos feels like a great addition for decals!

Some findings:

Depth is adjusted from from center when value is moved to 0 - which discussing with @RSlysz hard to do anything about, but could be adjusted in next QoL improvements pr, filed a ticket here: https://fogbugz.unity3d.com/f/cases/1308338/
Aside from pressing undo, there's no way to reset pivot position without changing position where decal is projected
"Modify the UV" button could benefit with an additional position gizmo(or a dot in the middle)
which would benefit if could be improved in future PRs

More info here: https://confluence.unity3d.com/display/HDRP/Update+Decal+Handles+Pivot

* [HDRP][Path Tracing] Improved volumetric scattering sampling #2840 * Update CHANGELOG.md * Fix HDRP tests with by enabling backbuffer instead of render texture (#2898) * add missing [UnityTest] attribute and use WaitForEndOfFrame * activate UseBackBuffer on SSR and SSAO scenes * update reference images for win editor * Update Vulkan linux screenshots * add missing config file to disable batch mode for DXR tests * increase VFX tests timeout to handle complex scenes with many shaders and XR variants Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Merge Hd/bugfix (#2928) * [HDRP] Fix coat normal space (#2888) * Fix coat normal space * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Avoid issues causing faulty transitions in shadows (resulting in no shadows with unconventional aspect ratio) (#2776) * Fixed volume component tooltips using the same parameter name (#2754) * Use the proper history info for Bicubic resampling in TAA (#2759) * Use proper info for previous buffer info * changelog * Fixed lookdev movement (#2757) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix issue with saving some quality settings in volume overrides (#2758) * Fix issue with saving some quality settings volume overrides * Fix typo in changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fixed NullReferenceException in HDRenderPipeline.UpgradeResourcesIfNeeded (case 1292524) (#2765) * fix issue with confusing text (#2766) * Fix * Fix white dots * Changelog * Rename the sunrise icon to fix typo, causing issue with 2x resolution loading. (#2809) * [HDRP] Rename HDRP to HD Render Pipeline in menu item (#2819) * [HDRP] Update HDRP menu in shader graph * Update CHANGELOG.md * HDRP/Fix package version showing package after the last "verified" package (#2783) * Fix typo * Remove last version checker from wizard and add link to package manager instead * Update CHANGELOG.md * Update documentation * Update Render-Pipeline-Wizard.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Revert bad changelog merge * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> * Fixed invalid loop length for probe baking (case 1289680) (#2830) * Fixed invalid loop length for probe baking (case 1289680) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix volumetric fog with XR single-pass (#2823) * fix volumetric fog with XR single-pass rendering * update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix rendering issues for the first frame (#2836) * Fix first frame exposure, depth pyramid / AO * Update changelog * Comment * Typo * Add missing RenderGraphBuilder.ReadTexture call * Move ComputePackedMipChainInfo at the beginning of ExecuteWithRenderGraph Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 5001_Fog_FogFallback.png * Revert "Update 5001_Fog_FogFallback.png" This reverts commit 2653b9c. * Update 5001_Fog_FogFallback.unity * Fix AOV API for render graph (#2909) * Fix AOV api in rendergraph # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs * Update changelog * Fix a small discrepancy in the marker placement in light intensity sliders (#2924) * Update CHANGELOG.md * Fix issue with VT spewing errors when transparent and opaque are disabled (#2925) * Fix * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a bug in the sphere-aabb light cluster (case 1294767). (#2920) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Move EndCameraRendering callback out of the profiling scope (#2917) * Move EndCameraRendering callback out of the profiling scope * added a comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed baked light being included into the ray tracing light cluster (case 1296203). (#2915) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Handle all enums the same way for UI (#2913) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Changed the message when the graphics device doesn't support ray tracing (case 1287355). (#2916) * [HDRP] Fix default blocks for Hair and Eye shader graphs (#2919) * Fixed default eye shader blocks * Fix missing emission block in hair shader * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Init scene camera debug framesettings (#2931) * Fixed using the wrong method to define if a light should be included in the light cluster depending on its baking status. (#2932) * - Fixed using the wrong method to define if a light should be included in the light cluster depending on its baking status. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Change the behavior of custom passes when the volume is disabled (#2930) * Changed the behavior of custom passes when the Custom Pass Volume component is disabled * Updated changelog * Fixed display of LOD Bias and maximum level in frame settings when using Quality Levels (#2921) * Fixed display of LOD Bias and maximum level in frame settings when using Quality Levels * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue when trying to open a look dev env library when Look Dev is not supported. (#2929) * Fixed an issue when trying to open a look dev env library when Look Dev is not supported. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable Reflector for Spotlight by default * - Fixed shader graph not supporting indirectdxr multibounce (case 1294694). (#2933) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed the planar depth texture not being properly created and rendered to (case 1299617). (#2926) * Fixed the planar depth texture not being properly created and rendered to (case 1299617). * adding comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed C# 8 compilation issue with turning on nullable checks (case 1300167) (#2949) * Fixed C# 8 compilation issue with turning on nullable checks - bis (#2951) * Fixed C# 8 compilation issue with turning on nullable checks (case 1300167) * Update MaterialDebug.cs * Fix scripting light test with enableReflector true by default * Fixed affects AO for deacl materials (#2950) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed case where material keywords would not get setup before usage (#2961) * Update CHANGELOG.md Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Frédéric Vauchelles <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Merge Hd/bugfix #2973 * Slight modification of 103_ReflectionQuality test to increase coverage with multibounce RTR (#2978) * Slight modify of test * reference image update * Fixed an issue with material using distortion from ShaderGraph init after Material creation (case 1294026) #2982 * Enable GetSamplePosition on metal (#2988) * HDRP docs bugfixes #2993 * Improved reflector property tooltip (#2994) * Fixed light reflector typo * Updated tooltip text to be more specific. Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * Fix timing issues with accumulation motion blur #2999 * Hdrp/update decal handles pivot #3001 * fix alpha test screenshots * Formatting Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Frédéric Vauchelles <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>

RSlysz added 6 commits January 6, 2021 15:07

Making a transform handle projected on a side

8ad03d4

clean

3d189b3

update offset in inspector

eadb3a1

Fix handle local coordinate systems

03fe677

Add missing Undo

5b48a5f

Had color and opacity in preferences

e42c590

RSlysz added SRP HDRP labels Jan 6, 2021

RSlysz requested review from a team, JulienIgnace-Unity and fredericv-unity3d January 6, 2021 16:39

Update CHANGELOG.md

1a5ee32

fredericv-unity3d suggested changes Jan 7, 2021

View reviewed changes

Adding feedbacks

0b04775

RSlysz requested a review from alex-vazquez January 7, 2021 09:41

RSlysz added 3 commits January 7, 2021 18:15

Change Size and ProjectionDepth to scale around pivot point

b5bffe0

Modify the bixe sizing edit modes to not touch transform any more

3bdc6b2

For better placment with prefabs

Update tooltip

ea4dde4

RSlysz added 2 commits January 11, 2021 13:37

Update documentation

21d850a

fix formating

5a89574

RSlysz requested a review from JordanL8 January 11, 2021 13:53

RSlysz added 2 commits January 11, 2021 14:56

Update documentation (missing color location)

0ccf247

clean unneaded comments

f326fef

JordanL8 suggested changes Jan 11, 2021

View reviewed changes

JulienIgnace-Unity approved these changes Jan 14, 2021

View reviewed changes

Update documentation

5a64b78

RSlysz requested a review from JordanL8 January 14, 2021 16:38

RSlysz requested a review from fredericv-unity3d January 14, 2021 16:38

JordanL8 approved these changes Jan 14, 2021

View reviewed changes

JulienIgnace-Unity approved these changes Jan 14, 2021

View reviewed changes

fredericv-unity3d approved these changes Jan 15, 2021

View reviewed changes

alex-vazquez reviewed Jan 19, 2021

View reviewed changes

sebastienlagarde added the needs-backport-2021.1 label Jan 19, 2021

Clean and clarify with last feedbacks

523adec

alex-vazquez approved these changes Jan 20, 2021

View reviewed changes

RSlysz and others added 3 commits January 20, 2021 11:44

Merge branch 'master' into HDRP/update-decal-handles-pivot

e911d2e

fix format

98b2060

Merge branch 'master' into HDRP/update-decal-handles-pivot

b27d81b

RSlysz marked this pull request as ready for review January 20, 2021 14:50

sebastienlagarde marked this pull request as draft January 20, 2021 18:41

sebastienlagarde marked this pull request as ready for review January 20, 2021 18:42

Add missing API to update pivot from script

607f609

Add falback when swap edit mode on mode 1

054b033

TomasKiniulis approved these changes Jan 22, 2021

View reviewed changes

sebastienlagarde merged commit 96ab646 into master Jan 22, 2021

sebastienlagarde deleted the HDRP/update-decal-handles-pivot branch January 22, 2021 18:26

alex-vazquez mentioned this pull request Feb 2, 2021

[XPipeline]Move Decal Gizmo color Register on Preferences/Colors #3311

Merged

This was referenced Mar 1, 2021

Hd/fix lookdev environment inspector undo [Hold] #2958

Closed

Hd/fix pivot size ratio percistency through 0 #3600

Merged

sebastienlagarde added backported-10.x and removed needs-backport-2021.1 labels Mar 2, 2021

sebastienlagarde pushed a commit that referenced this pull request Mar 2, 2021

Hdrp/update decal handles pivot #3001

94020c5

sebastienlagarde mentioned this pull request Mar 2, 2021

[backport 2021.1][HDRP] Various HDRP PR backport #3725

Merged

sebastienlagarde added the needs-backport-2021.1 label Aug 31, 2021

Hdrp/update decal handles pivot #3001

Hdrp/update decal handles pivot #3001

Uh oh!

Conversation

RSlysz commented Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SeanPuller commented Jan 7, 2021

Uh oh!

RSlysz commented Jan 8, 2021

Uh oh!

RSlysz commented Jan 11, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alex-vazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alex-vazquez left a comment

Choose a reason for hiding this comment

Uh oh!

RSlysz commented Jan 21, 2021

Uh oh!

RSlysz commented Jan 22, 2021

Uh oh!

TomasKiniulis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

RSlysz commented Jan 6, 2021 •

edited

Loading

TomasKiniulis left a comment •

edited

Loading