Suggest mode 2/7: suggestion storage, REST controller, and provider - #80428
Open
adamsilverstein wants to merge 2 commits into
Open
Suggest mode 2/7: suggestion storage, REST controller, and provider#80428adamsilverstein wants to merge 2 commits into
adamsilverstein wants to merge 2 commits into
Conversation
Adds the comment-meta storage backbone: _wp_suggestion payload meta and sanitization (64KB cap, KSES on block snapshots), the 7.1 REST comment controller subclass scoped to suggestion lifecycle updates, the comment-meta SuggestionsProvider (create/update/delete, apply/reject for attribute and structural operations, schema versioning + migration), the pending-suggestion overlay store with its debounced write queue, and the auto-save loop that persists overlay entries as note comments. Inline (marker-based) operations are added by a later layer. Nothing captures suggestions yet - that starts in the next layer.
This was referenced Jul 17, 2026
|
Size Change: +4.04 kB (+0.05%) Total Size: 7.82 MB 📦 View Changed
|
# Conflicts: # tools/eslint/suppressions.json
adamsilverstein
marked this pull request as ready for review
August 5, 2026 22:24
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #73411
What's in this PR
Adds the comment-meta storage backbone: _wp_suggestion payload meta and
sanitization (64KB cap, KSES on block snapshots), the 7.1 REST comment
controller subclass scoped to suggestion lifecycle updates, the
comment-meta SuggestionsProvider (create/update/delete, apply/reject for
attribute and structural operations, schema versioning + migration), the
pending-suggestion overlay store with its debounced write queue, and the
auto-save loop that persists overlay entries as note comments. Inline
(marker-based) operations are added by a later layer. Nothing captures
suggestions yet - that starts in the next layer.
Diagram
There is no UI in this layer. It is the write path that turns an edit into a stored suggestion, plus the read path back out:
Testing
This is one layer of the stack. To exercise the whole feature, #78994 bundles all seven layers into one branch and builds it in Playground:
👉 https://playground.wordpress.net/gutenberg.html?pr=78994
Enable Gutenberg > Experiments > Collaboration > Suggestion Mode, then follow the walkthrough in #73411, which also explains how to review the stack layer by layer.
Suggest mode stack
This rebuilds the manually-stacked Suggest mode work (#73411) as a GitHub Stack of 7 small, independently reviewable PRs, each building on the one below it:
The whole feature can be exercised end-to-end via the combined testing branch #78994 (Playground). Behind the "Suggestion Mode" experiment (Gutenberg > Experiments).