Skip to content

Suggest mode 5/7: inline suggestion operations - #80431

Open
adamsilverstein wants to merge 2 commits into
suggest/inline-markersfrom
suggest/inline-ops
Open

Suggest mode 5/7: inline suggestion operations#80431
adamsilverstein wants to merge 2 commits into
suggest/inline-markersfrom
suggest/inline-ops

Conversation

@adamsilverstein

@adamsilverstein adamsilverstein commented Jul 17, 2026

Copy link
Copy Markdown
Member

Part of #73411

What's in this PR

Adds the suggestion-specific layer on top of the marker primitive: create,
accept, and reject inline text (add/del) and formatting suggestions
(operations.js); the pure reconcilers that turn a text edit or a format
toggle into marker actions (reconcile-edit.js, reconcile-format.js); word/
line delete-range resolution; strip-markers for clean attribute snapshots;
findSuggestionText/findMarkerText helpers; and the annotate-suggestions hook.
Still pure modules - the keyboards and reconcilers that call them into the
live editor land in the final step.

Diagram

Pure transforms over a rich-text value: write a marker, resolve it on accept or reject, strip it for output.

Inline suggestion operations grouped into write, resolve and strip, with a worked type-over example

Testing

This is one layer of the stack. To exercise the whole feature, #78994 bundles all seven layers into one branch and builds it in Playground:

Test in WordPress Playground

👉 https://playground.wordpress.net/gutenberg.html?pr=78994

Enable Gutenberg > Experiments > Collaboration > Suggestion Mode, then follow the walkthrough in #73411, which also explains how to review the stack layer by layer.


Suggest mode stack

This rebuilds the manually-stacked Suggest mode work (#73411) as a GitHub Stack of 7 small, independently reviewable PRs, each building on the one below it:

  1. #80427 - editor intent (edit/suggest/view) + experiment gate
  2. #80428 - suggestion storage, REST controller, provider
  3. #80429 - block-level capture (attribute + structural)
  4. #80430 - inline marker primitive
  5. #80431 - inline suggestion operations
  6. #80432 - review UI (Apply/Reject sidebar + summary)
  7. #80433 - inline live wiring, docs, e2e

The whole feature can be exercised end-to-end via the combined testing branch #78994 (Playground). Behind the "Suggestion Mode" experiment (Gutenberg > Experiments).

Adds the suggestion-specific layer on top of the marker primitive: create,
accept, and reject inline text (add/del) and formatting suggestions
(operations.js); the pure reconcilers that turn a text edit or a format
toggle into marker actions (reconcile-edit.js, reconcile-format.js); word/
line delete-range resolution; strip-markers for clean attribute snapshots;
findSuggestionText/findMarkerText helpers; and the annotate-suggestions hook.
Still pure modules - the keyboards and reconcilers that call them into the
live editor land in the final step.
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 7.83 MB

compressed-size-action

@adamsilverstein
adamsilverstein marked this pull request as ready for review August 5, 2026 22:24
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Flaky tests detected in 56c4083.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/31052261814
📝 Reported issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Editor /packages/editor [Type] Feature New feature to highlight in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant