Suggest mode 5/7: inline suggestion operations - #80431
Conversation
Adds the suggestion-specific layer on top of the marker primitive: create, accept, and reject inline text (add/del) and formatting suggestions (operations.js); the pure reconcilers that turn a text edit or a format toggle into marker actions (reconcile-edit.js, reconcile-format.js); word/ line delete-range resolution; strip-markers for clean attribute snapshots; findSuggestionText/findMarkerText helpers; and the annotate-suggestions hook. Still pure modules - the keyboards and reconcilers that call them into the live editor land in the final step.
|
Size Change: 0 B Total Size: 7.83 MB |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 56c4083. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/31052261814
|
Part of #73411
What's in this PR
Adds the suggestion-specific layer on top of the marker primitive: create,
accept, and reject inline text (add/del) and formatting suggestions
(operations.js); the pure reconcilers that turn a text edit or a format
toggle into marker actions (reconcile-edit.js, reconcile-format.js); word/
line delete-range resolution; strip-markers for clean attribute snapshots;
findSuggestionText/findMarkerText helpers; and the annotate-suggestions hook.
Still pure modules - the keyboards and reconcilers that call them into the
live editor land in the final step.
Diagram
Pure transforms over a rich-text value: write a marker, resolve it on accept or reject, strip it for output.
Testing
This is one layer of the stack. To exercise the whole feature, #78994 bundles all seven layers into one branch and builds it in Playground:
👉 https://playground.wordpress.net/gutenberg.html?pr=78994
Enable Gutenberg > Experiments > Collaboration > Suggestion Mode, then follow the walkthrough in #73411, which also explains how to review the stack layer by layer.
Suggest mode stack
This rebuilds the manually-stacked Suggest mode work (#73411) as a GitHub Stack of 7 small, independently reviewable PRs, each building on the one below it:
The whole feature can be exercised end-to-end via the combined testing branch #78994 (Playground). Behind the "Suggestion Mode" experiment (Gutenberg > Experiments).