Skip to content

Notes: detach core's mention kses filter in the baseline strip test - #80656

Merged
adamsilverstein merged 1 commit into
trunkfrom
fix/mention-kses-baseline-test
Jul 23, 2026
Merged

Notes: detach core's mention kses filter in the baseline strip test#80656
adamsilverstein merged 1 commit into
trunkfrom
fix/mention-kses-baseline-test

Conversation

@adamsilverstein

@adamsilverstein adamsilverstein commented Jul 23, 2026

Copy link
Copy Markdown
Member

What?

Fixes the Tests_Notes_Mention_Kses::test_comment_kses_strips_mention_span_by_default failure that started showing up on trunk CI runs against WordPress trunk.

Why?

WordPress trunk now ships the note mention span allowance natively - see https://core.trac.wordpress.org/changeset/62832 (the core backport of #80528). The baseline test proves the allowance is required by removing the notes filter and asserting the chip gets stripped, but it only removes Gutenberg's gutenberg_notes_allow_mention_span callback. On WP trunk, core's own _wp_kses_allow_note_mention_span is still hooked, so the span survives and the assertion fails. Every Gutenberg PR is currently red on the PHP unit test jobs because of this.

Worth noting the plugin code itself coexists fine with the core change - lib/compat/wordpress-7.1/block-comments.php already guards with function_exists( '_wp_kses_allow_note_mention_span' ), which is why only this one baseline test fails.

How?

Detach core's filter alongside Gutenberg's before running the baseline assertion. Removing a filter that isn't hooked is a no-op, so no version gating is needed, and WP_UnitTestCase restores hooks after each test.

Testing Instructions

The failure only reproduces against WordPress trunk, eg. the trunk unit test run https://github.com/WordPress/gutenberg/actions/runs/30034562918. The PHP unit test jobs on this PR should go green, including the WP trunk variant.

To check locally against the default test environment (where this change is a no-op):

  1. npm run wp-env-test start
  2. vendor/bin/phpunit phpunit/tests/notes-mention-kses-test.php

Related: #80528

@adamsilverstein
Detach core's note mention kses filter in the baseline strip test
ae645bf 
WordPress trunk now ships the note mention span allowance natively
(r62832, hooked as _wp_kses_allow_note_mention_span), so removing only
Gutenberg's filter no longer restores default kses behavior and the
baseline assertion fails against WP trunk. Removing a filter that is
not hooked is a no-op, so no version gating is needed.
@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@adamsilverstein adamsilverstein self-assigned this Jul 23, 2026
@adamsilverstein adamsilverstein added the [Type] Bug An existing feature does not function as intended label Jul 23, 2026
@adamsilverstein adamsilverstein added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Jul 23, 2026
@adamsilverstein
adamsilverstein requested a review from Mamaduka July 23, 2026 23:04
@adamsilverstein
adamsilverstein merged commit 4eba946 into trunk Jul 23, 2026
56 of 58 checks passed
@adamsilverstein
adamsilverstein deleted the fix/mention-kses-baseline-test branch July 23, 2026 23:35
@adamsilverstein

adamsilverstein commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

Thanks @ellatrix!

@github-actions github-actions Bot added this to the Gutenberg 23.7 milestone Jul 23, 2026
@t-hamano

t-hamano commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

I found that the following error is occurring on the wp/7.1 branch. This should be resolved by backporting this PR.

There was 1 failure:

1) Tests_Notes_Mention_Kses::test_comment_kses_strips_mention_span_by_default
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Hi @admin!'
+'Hi <span class="wp-note-mention user-2">@admin</span>!'

/var/www/html/wp-content/plugins/gutenberg/phpunit/tests/notes-mention-kses-test.php:39

@t-hamano t-hamano added the Backport to WP 7.1 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 24, 2026
@github-actions github-actions Bot removed the Backport to WP 7.1 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 24, 2026
gutenbergplugin pushed a commit that referenced this pull request Jul 24, 2026
@adamsilverstein @ellatrix @gutenbergplugin
Detach core's note mention kses filter in the baseline strip test (#8…
5fbdee6 
…0656)

Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

I just cherry-picked this PR to the wp/7.1 branch to get it included in the next release: 5fbdee6

@github-actions github-actions Bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Jul 24, 2026
@jonathanbossenger jonathanbossenger added the [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting label Jul 29, 2026
@t-hamano t-hamano mentioned this pull request Jul 29, 2026
Closed
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Jul 29, 2026
wildworks
General: Bump the pinned hash for Gutenberg to fd715a6.
571c279 
This updates the pinned commit hash of the Gutenberg repository from `4997026b75c922d8a6f77a03d72ed7cad04c7073` to `fd715a6833679d098d9fee84b642f8f1bc27341b`.

A full list of changes included in this commit can be found on GitHub: 
WordPress/gutenberg@4997026...fd715a6

- Update view config API versioning (WordPress/gutenberg#80319)
- Perf Tests: Fix 'Selecting blocks' metric reporting 0 ms (WordPress/gutenberg#80524)
- Notes: Register the inline note format at import time (WordPress/gutenberg#80576)
- Media: Stop forcing crossorigin on IMG tags in media templates (WordPress/gutenberg#80532)
- GradientPicker: select by slug so two presets sharing a gradient keep their identity (WordPress/gutenberg#80554)
- Media Editor: Show a loading state while the cropped file loads (WordPress/gutenberg#80460)
- Remove default paragraph from tab-panel template (WordPress/gutenberg#80565)
- Global Styles: Resolve link element styles in block inspector controls for blocks that are links (WordPress/gutenberg#80607)
- Media REST API: Backport sideload from url path upload size check (WordPress/gutenberg#80659)
- Rich text: remove tabIndex from editable elements again to fix shift+click selection (WordPress/gutenberg#80651)
- Gallery: make dynamic mode conversion a single undo level (WordPress/gutenberg#80665)
- Background image control: Remove duplicated focus ring (WordPress/gutenberg#80671)
- Detach core's note mention kses filter in the baseline strip test (WordPress/gutenberg#80656)
- wp-build: sync the page template preload field list with core-data (WordPress/gutenberg#80648)
- Read the contentEditable attribute in ownsSelection, not isContentEditable (WordPress/gutenberg#80549)
- Writing flow: extend block selections with shift+arrow when there is no native selection (WordPress/gutenberg#80687)
- Notes: Capture the target block before saving a block-level note (WordPress/gutenberg#80690)
- Theme JSON: Level block-level preset class specificity with :where() (WordPress/gutenberg#80657)
- Notes: Sync the sidebar selection to the inline marker under the caret (WordPress/gutenberg#80610)
- Writing flow: use isMultiSelecting for shift+click (WordPress/gutenberg#80286) (WordPress/gutenberg#80726)
- Block supports: Return from layout support before resolving global settings (WordPress/gutenberg#80771)
- Notes: Report save success consistently from note actions (WordPress/gutenberg#80748)
- Dynamic Gallery: Rename toolbar button to Detach and add a modal explaining what will happen (WordPress/gutenberg#80727) (WordPress/gutenberg#80774)
- ToolsPanel: Migrate styles to an SCSS Module (WordPress/gutenberg#80445) (WordPress/gutenberg#80800)
- Add a responsiveEditingEnabled editor setting to hide the Responsive styles option (WordPress/gutenberg#80814)
- iOS: remove jumping hack, add typewriter (WordPress/gutenberg#74596)
- Writing flow: stop the page scrolling on caret moves within blocks taller than the viewport (WordPress/gutenberg#80708)
- Global Styles: Put the inheritance UI behind a Gutenberg experiment (… (WordPress/gutenberg#80818)
- Notes: Cancel in-flight hover highlight when focus leaves a note thread (WordPress/gutenberg#80752)
- Block Editor: Try to fix typing performance regression (WordPress/gutenberg#80507)
- List Block: Preserve ordered type on indent (WordPress/gutenberg#75353)
- Make editableRoot a private block setting Symbol, not a public support (WordPress/gutenberg#80820)
- Fix cursor position during forward delete of empty blocks (WordPress/gutenberg#80827)
- Navigation: Fixes `aria-expanded` not updating on hover submenu inside overlay (WordPress/gutenberg#80828)
- Remove redundant @jest-environment jsdom pragma and lint against it (WordPress/gutenberg#80676)
- View config: reject shape-mismatched merges, define empty-array semantics, strip nulls from appended members (WordPress/gutenberg#80829)
- Editor: leave undo to the browser in fields that handle their own undo (WordPress/gutenberg#80768)
- Fix: New route-based admin pages are empty when no JS (WordPress/gutenberg#80839)

Props wildworks.
See #65529.

git-svn-id: https://develop.svn.wordpress.org/trunk@62896 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jul 29, 2026
@t-hamano
General: Bump the pinned hash for Gutenberg to fd715a6.
3f0381a 
This updates the pinned commit hash of the Gutenberg repository from `4997026b75c922d8a6f77a03d72ed7cad04c7073` to `fd715a6833679d098d9fee84b642f8f1bc27341b`.

A full list of changes included in this commit can be found on GitHub: 
WordPress/gutenberg@4997026...fd715a6

- Update view config API versioning (WordPress/gutenberg#80319)
- Perf Tests: Fix 'Selecting blocks' metric reporting 0 ms (WordPress/gutenberg#80524)
- Notes: Register the inline note format at import time (WordPress/gutenberg#80576)
- Media: Stop forcing crossorigin on IMG tags in media templates (WordPress/gutenberg#80532)
- GradientPicker: select by slug so two presets sharing a gradient keep their identity (WordPress/gutenberg#80554)
- Media Editor: Show a loading state while the cropped file loads (WordPress/gutenberg#80460)
- Remove default paragraph from tab-panel template (WordPress/gutenberg#80565)
- Global Styles: Resolve link element styles in block inspector controls for blocks that are links (WordPress/gutenberg#80607)
- Media REST API: Backport sideload from url path upload size check (WordPress/gutenberg#80659)
- Rich text: remove tabIndex from editable elements again to fix shift+click selection (WordPress/gutenberg#80651)
- Gallery: make dynamic mode conversion a single undo level (WordPress/gutenberg#80665)
- Background image control: Remove duplicated focus ring (WordPress/gutenberg#80671)
- Detach core's note mention kses filter in the baseline strip test (WordPress/gutenberg#80656)
- wp-build: sync the page template preload field list with core-data (WordPress/gutenberg#80648)
- Read the contentEditable attribute in ownsSelection, not isContentEditable (WordPress/gutenberg#80549)
- Writing flow: extend block selections with shift+arrow when there is no native selection (WordPress/gutenberg#80687)
- Notes: Capture the target block before saving a block-level note (WordPress/gutenberg#80690)
- Theme JSON: Level block-level preset class specificity with :where() (WordPress/gutenberg#80657)
- Notes: Sync the sidebar selection to the inline marker under the caret (WordPress/gutenberg#80610)
- Writing flow: use isMultiSelecting for shift+click (WordPress/gutenberg#80286) (WordPress/gutenberg#80726)
- Block supports: Return from layout support before resolving global settings (WordPress/gutenberg#80771)
- Notes: Report save success consistently from note actions (WordPress/gutenberg#80748)
- Dynamic Gallery: Rename toolbar button to Detach and add a modal explaining what will happen (WordPress/gutenberg#80727) (WordPress/gutenberg#80774)
- ToolsPanel: Migrate styles to an SCSS Module (WordPress/gutenberg#80445) (WordPress/gutenberg#80800)
- Add a responsiveEditingEnabled editor setting to hide the Responsive styles option (WordPress/gutenberg#80814)
- iOS: remove jumping hack, add typewriter (WordPress/gutenberg#74596)
- Writing flow: stop the page scrolling on caret moves within blocks taller than the viewport (WordPress/gutenberg#80708)
- Global Styles: Put the inheritance UI behind a Gutenberg experiment (… (WordPress/gutenberg#80818)
- Notes: Cancel in-flight hover highlight when focus leaves a note thread (WordPress/gutenberg#80752)
- Block Editor: Try to fix typing performance regression (WordPress/gutenberg#80507)
- List Block: Preserve ordered type on indent (WordPress/gutenberg#75353)
- Make editableRoot a private block setting Symbol, not a public support (WordPress/gutenberg#80820)
- Fix cursor position during forward delete of empty blocks (WordPress/gutenberg#80827)
- Navigation: Fixes `aria-expanded` not updating on hover submenu inside overlay (WordPress/gutenberg#80828)
- Remove redundant @jest-environment jsdom pragma and lint against it (WordPress/gutenberg#80676)
- View config: reject shape-mismatched merges, define empty-array semantics, strip nulls from appended members (WordPress/gutenberg#80829)
- Editor: leave undo to the browser in fields that handle their own undo (WordPress/gutenberg#80768)
- Fix: New route-based admin pages are empty when no JS (WordPress/gutenberg#80839)

Props wildworks.
See #65529.
Built from https://develop.svn.wordpress.org/trunk@62896


git-svn-id: http://core.svn.wordpress.org/trunk@62163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellatrix ellatrix ellatrix approved these changes
@aduth aduth Awaiting requested review from aduth
@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta
@Mamaduka Mamaduka Awaiting requested review from Mamaduka

Assignees

@adamsilverstein adamsilverstein

Labels

Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 23.7

Development

Successfully merging this pull request may close these issues.

4 participants

@adamsilverstein @t-hamano @ellatrix @jonathanbossenger