Build/Test Tools: Allow the PHPUnit runner to be set by a repository variable. - #12745
Build/Test Tools: Allow the PHPUnit runner to be set by a repository variable.#12745lancewillett wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
This PR adds an optional GitHub Actions repository-variable override so maintainers can redirect the reusable PHPUnit workflow’s job runner without editing workflow files, while preserving the existing default behavior.
Changes:
- Updates the reusable PHPUnit workflow job to prefer
vars.PHPUNIT_RUNNER(if set) over the existinginputs.osrunner selection. - Keeps backward compatibility by falling back to
inputs.oswhen the variable is unset/empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
For this to work, @bazza or another GitHub admin will need to flip the How to route the PHPUnit matrices to a specific runnerThis change is a no-op until a
Turn it on
Turn it off
Notes
|
…variable.
Change `runs-on` in the reusable PHPUnit workflow to `${{ vars.PHPUNIT_RUNNER || inputs.os }}`. With the variable unset (the default), jobs run exactly as before.
When a maintainer sets `PHPUNIT_RUNNER` to a runner label, the PHPUnit matrices run on that runner instead—useful for directing them to a dedicated runner during high-load release windows, without editing the workflow.
No input is added or made required, so every branch that calls this workflow at `@trunk` stays compatible.
Developed in: #12745
Props barry.
Fixes #65749.
git-svn-id: https://develop.svn.wordpress.org/trunk@62891 602fd350-edb4-49c9-b593-d223f7449a82
…variable.
Change `runs-on` in the reusable PHPUnit workflow to `${{ vars.PHPUNIT_RUNNER || inputs.os }}`. With the variable unset (the default), jobs run exactly as before.
When a maintainer sets `PHPUNIT_RUNNER` to a runner label, the PHPUnit matrices run on that runner instead—useful for directing them to a dedicated runner during high-load release windows, without editing the workflow.
No input is added or made required, so every branch that calls this workflow at `@trunk` stays compatible.
Developed in: WordPress/wordpress-develop#12745
Props barry.
Fixes #65749.
Built from https://develop.svn.wordpress.org/trunk@62891
git-svn-id: http://core.svn.wordpress.org/trunk@62158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Allows the PHPUnit runner to be directed by a repository variable, defaulting to the current runner.
reusable-phpunit-tests-v3.ymlchanges itsruns-onto${{ vars.PHPUNIT_RUNNER || inputs.os }}. With thePHPUNIT_RUNNERvariable unset (the default), jobs run oninputs.os(ubuntu-24.04) exactly as before. When a maintainer setsPHPUNIT_RUNNERto a runner label, the PHPUnit matrices run on that runner instead—useful for directing them to a dedicated runner during high-load release windows, without editing the workflow.@trunk; no input is added or made required.varsis available inruns-on, so the override is valid.Trac: https://core.trac.wordpress.org/ticket/65749