[electrophysiology_browser] On-demand file download tarring - #10481
Conversation
2fcd4ef to
fffb14c
Compare
a1274cd to
933c15c
Compare
|
Since this approach request came from @driusan I guess I am gonna assign this to you. I tested it locally (of course) but feel free to re-assign it if you prefer. |
There was a problem hiding this comment.
Most of these endpoints don't work, like /bidsfiles/channels, for example.
The issue was not introduced by this PR but it makes this switch problematic.
This join is responsible for the channels, picked as an example, and channels works for me If I change that line to:
LEFT JOIN physiological_channel pc
ON (pc.PhysiologicalFileID = f.PhysiologicalFileID)
and add this at the end, to similarly obtain one:
GROUP BY pc.PhysiologicalFileID
I didn't look too deeply into why this is the case, but that query can use some love.
That query in the DB returns NULL for everything except filelocation and archive_file_path, prior to my change, which returns the channel_file_path
lmk if you can't reproduce it
933c15c to
33b6346
Compare
|
Oh, good catch @jeffersoncasimir, I did not run into that issue during my original tests, but after looking at your explanation and doing more tests, I can reproduce. I think the problem is that the join subqueries use I rebased on 29-release and added a commit to fix the query, it fixed it for me, tell me if you are still having issues. |
This makes two changes; - Replace the download links in the electrophysiology browser to use the LORIS API instead of `get_file.php`. - Add a new `ArchiveStream` class to LORIS core to tar on-demand a file or directory and make it available to download. This new class is adopted in the electrophysiology browser to make it possible to download CTF directories for MEG.
This makes two changes; - Replace the download links in the electrophysiology browser to use the LORIS API instead of `get_file.php`. - Add a new `ArchiveStream` class to LORIS core to tar on-demand a file or directory and make it available to download. This new class is adopted in the electrophysiology browser to make it possible to download CTF directories for MEG.
This makes two changes; - Replace the download links in the electrophysiology browser to use the LORIS API instead of `get_file.php`. - Add a new `ArchiveStream` class to LORIS core to tar on-demand a file or directory and make it available to download. This new class is adopted in the electrophysiology browser to make it possible to download CTF directories for MEG.
Alternative to #10411
Description
This PR makes two changes;
get_file.php.ArchiveStreamclass to LORIS core to tar on-demand a file or directory and make it available to download. This new class is adopted in the electrophysiology browser to make it possible to download CTF directories for MEG.