[biobank] [Multilingual] Fixed errors for loading most of the pages of the module + add missing translations in French and Spanish#10801
Open
HachemJ wants to merge 10 commits into
Conversation
github-actions
Bot
added
Language: Javascript
HachemJ
force-pushed
the
FixTranslationEsAndFrInBiobank
branch
from
49f9d01 to
6243341
Compare
HachemJ
added
the
29.0.0 - Bugs
…, add container etc.
…xisting ones' format
HachemJ
changed the title
HachemJ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR :
adds missing translations in french
adds missing translations in spanish
fixes the format multiple untranslated strings ( e.g., t('biobank:Comments') -> t('Comments', {ns: 'biobank}) )
fixes the 'Add Specimen' functionality indirectly (It should be verified by someone familiar with the module, as I couldn’t find detailed instructions in TestPlan.md)
fixes multiple t() calls that were missing a namespace, preventing them from being translated.
fixes access to every button in the four tabs (Specimens, Containers, Pools, Shipments) that were broken because of multilingual related code.
Note: not every button function properly, for example it is currently not possible to save the form when creating a shipment: a 500 error is returned in the console.
^^
I think that it is outside of the scope of this PR that mostly fixes multilingual related code/files.
Another note: I'm having difficulties understanding why 'Containers' isn't pluralized when using t(..., {ns: ..., count: n}) with n > 1.
It is currently a bug of this PR.
At least three other instances (Specimens, Pools could benefit from the plural design using msgid_plural in the translation files but I left it as is because I couldn't make work the existing 'Containers' one properly.
Note: I used AI for Spanish translations.
Link(s) to related issue(s)