Skip to content

[media] Translate Project in media and imaging_browser modules#10988

Merged
driusan merged 3 commits into
aces:29.0-releasefrom
driusan:MediaProjectTranslate
Jul 23, 2026
Merged

[media] Translate Project in media and imaging_browser modules#10988
driusan merged 3 commits into
aces:29.0-releasefrom
driusan:MediaProjectTranslate

Conversation

@driusan

@driusan driusan commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Extracts the Project translation part of #10548 which did not cause test failures into a different PR.

Extracts the Project translation part of aces#10548 which did
not cause test failures into a different PR.
@github-actions github-actions Bot added the Language: PHP PR or issue that update PHP code label Jul 22, 2026
@github-actions github-actions Bot added the Module: imaging_browser PR or issue related to imaging_browser module label Jul 22, 2026
@driusan driusan changed the title [media] Translate Project in media module [media] Translate Project in media and imaging_browser modules Jul 22, 2026
@HachemJ HachemJ self-assigned this Jul 23, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 23, 2026
@driusan driusan added the Multilingual Any tasks related to making LORIS multilingual label Jul 23, 2026
@HachemJ

HachemJ commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

'Rye' is translated into 'Seigle' in french so the following images show that the translations went through.

imaging_browser:
image

media:
image

statistics: there is already a translation for the project label done inside the module but it would simplify code if reverted. and other similar instances can be reverted too because you just included the translation of the name in the utility function itself.

here's a screenshot after I applied (it can be left as is, would still work but better to remove this redundancy)

diff --git a/modules/statistics/php/stats_demographic.class.inc b/modules/statistics/php/stats_demographic.class.inc
index 044f677b0..e8832fba1 100644
--- a/modules/statistics/php/stats_demographic.class.inc
+++ b/modules/statistics/php/stats_demographic.class.inc
@@ -237,10 +237,7 @@ class Stats_Demographic extends \NDB_Form

         $userProjectsIDs = $user->getProjectIDs();
         foreach ($userProjectsIDs as $ProjectID) {
-            $projects["$ProjectID"] = dgettext(
-                'Project',
-                $allProjectList["$ProjectID"]
-            );
+            $projects["$ProjectID"] = $allProjectList["$ProjectID"];
         }

         if ($user->hasPermission('access_all_profiles')) {
image

@github-actions github-actions Bot added the Module: statistics PR or issue related to statistics module label Jul 23, 2026
@driusan

driusan commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

@HachemJ Reverted the statistics double translation

@HachemJ HachemJ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your last change in the imaging_browser module successfully translates the project labels in the 'Project' column of the table displayed in imaging_browser. LGTM

@HachemJ HachemJ added the Passed manual tests PR has been successfully tested by at least one peer label Jul 23, 2026
@driusan
driusan merged commit 107d689 into aces:29.0-release Jul 23, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: PHP PR or issue that update PHP code Module: imaging_browser PR or issue related to imaging_browser module Module: statistics PR or issue related to statistics module Multilingual Any tasks related to making LORIS multilingual Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants