Skip to content

[behavioural_qc] Add missing db translations - #11018

Merged
driusan merged 3 commits into
aces:29.0-releasefrom
HachemJ:AddMissingDbTranslationsBehaviouralQc
Jul 28, 2026
Merged

[behavioural_qc] Add missing db translations#11018
driusan merged 3 commits into
aces:29.0-releasefrom
HachemJ:AddMissingDbTranslationsBehaviouralQc

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR adds the missing database translations for table entries in the Behavioural QC module.

I also removed a row with feedback_level = instrument that had no associated instrument entry. It appears to be invalid data and was causing a multilingual bug, so it seemed reasonable to remove it, assuming no tests depend on it.

Testing instructions (if applicable)

  1. git checkout HachemJ/AddMissingDbTranslationsBehaviouralQc
  2. delete project/locale
  3. copy raisinbread/locale into project/locale
  4. run make dev (make sure it ran the msgfmt --use-fuzzy -o table.mo table.po commands)
  5. Go to 'Clinical' -> 'Behavioural Quality Control'
  6. Switch the language to French

For each of the three tabs (Incomplete Forms, Data Conflicts and Behavioural Feedback):
7. Verify that the table entries are translated in each of the three tabs

Link(s) to related issue(s)

@github-actions github-actions Bot added RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Language: PHP PR or issue that update PHP code Module: behavioural_qc PR or issue related behavioural_qc module Multilingual Any tasks related to making LORIS multilingual labels Jul 27, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 27, 2026
@github-actions github-actions Bot added the Language: SQL PR or issue that update SQL code label Jul 27, 2026
@driusan

driusan commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

@HachemJ Can you revert the test_names part of this? The instrument name comes from NDB_BVL_Instrument::getFullName(), not the database. That table is not populated for all instruments.

We might need a different solution for test names

@driusan
driusan merged commit 850475a into aces:29.0-release Jul 28, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: PHP PR or issue that update PHP code Language: SQL PR or issue that update SQL code Module: behavioural_qc PR or issue related behavioural_qc module Multilingual Any tasks related to making LORIS multilingual RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants