Skip to content

[electrophysiology_browser] Fix French translations + typo (non-db only) - #11067

Open
HachemJ wants to merge 2 commits into
aces:29.0-releasefrom
HachemJ:FixTranslationsElectrophysiologyBrowser
Open

[electrophysiology_browser] Fix French translations + typo (non-db only)#11067
HachemJ wants to merge 2 commits into
aces:29.0-releasefrom
HachemJ:FixTranslationsElectrophysiologyBrowser

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR fixes the issue described in the corresponding issue report and corrects a minor UI typo by adding the missing trailing colon : to the 'Total events in recording' label.

Testing instructions (if applicable)

  1. Testing is recommended for someone who already has the visualization component set up, ideally @lapadulamichael who reported the issue. The setup to access the visualization component of the module which contains most of the fixes is documented in the module's README.md, so anyone else assigned to the PR should be able to set it up without difficulty.

Link(s) to related issue(s)

@github-actions github-actions Bot added Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Multilingual Any tasks related to making LORIS multilingual labels Jul 28, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 28, 2026
@lapadulamichael lapadulamichael self-assigned this Jul 28, 2026
@lapadulamichael
lapadulamichael self-requested a review July 28, 2026 16:11
@lapadulamichael

lapadulamichael commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@HachemJ @driusan

I noticed all of these are also in English. I am not sure if we actually do want to translate all of these or keep them universally in English. If we do decide to translate all of them then there still are some trial_type that were missed. If not, then we should revert the change for the ones that were already done.

image image image

@HachemJ

HachemJ commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@jeffersoncasimir Dave recommended you since you are familiar with the module. Can you draw the line on what's need to be translated or not? Please check Michael's last comment. Thank you

@christinerogers

Copy link
Copy Markdown
Contributor

@jeffersoncasimir Dave recommended you since you are familiar with the module. Can you draw the line on what's need to be translated or not? Please check Michael's last comment. Thank you

Jefferson can provide guidance for now.

Christine will follow up re prospect of future translation inboth BIDS #11146 and HED tags #11147 (embedded in RaisinBread) for future LORIS planning.

@jeffersoncasimir

Copy link
Copy Markdown
Contributor

@HachemJ @lapadulamichael

All these terms in red squares come from HED, BIDS fields and BIDS metadata (researcher chosen) and are currently not translatable.

We will mention it to the two groups, but it would be up to them to define the terms.

Note: I noticed at least one BIDS term that was translated that should not be: trial_type

@HachemJ

HachemJ commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@HachemJ @lapadulamichael

All these terms in red squares come from HED, BIDS fields and BIDS metadata (researcher chosen) and are currently not translatable.

We will mention it to the two groups, but it would be up to them to define the terms.

Note: I noticed at least one BIDS term that was translated that should not be: trial_type

Thanks @christinerogers @jeffersoncasimir . I’ll revert the trial_type translation for now and wait until we have more clarity on whether these terms should be translated and, if so, what the appropriate translations would be (at least in French since the goal of LORIS 29 is to have full French localization)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants