[Statistics] Update of README.md and test plan.#6463
Conversation
nicolasbrossard
added
23.0.0-testing
Category: Documentation
There was a problem hiding this comment.
what's the difference between "Automate Test on Travis_CI" and "Automate Test"?
There was a problem hiding this comment.
I removed ' on Travis_CI'.
driusan
left a comment
driusan
left a comment
There was a problem hiding this comment.
I'm not sure if it'll get confusing that the automated tests referred to in the statistics test plan are in the dashboard test.. should we move those too? Or at least explain which tests test it inside the []?
|
@driusan Yeah, I guess it makes more sense to move those tests from the dashboard to the stats module. I'll also remove the redundant |
|
@nicolasbrossard It might still be a good idea to reference which test it is that tests feature X in the test plan, so that anyone who wants can look it up. |
|
@sruthymathew123 @nicolasbrossard this PR seems to overlap with #6462 can you decide which one should go and close the other one please |
|
@ridz1208 My PR was kept. |
There was a problem hiding this comment.
I would prefer an order of magnitude on the number of candidates/sessions/instruments than a specific study. Except maybe raisinbread.
There was a problem hiding this comment.
The next commit will mention a reasonable display time for raisinbread.
|
@nicolasbrossard this has a conflict that needs to be resolved |
nicolasbrossard
force-pushed
the
stats_readme_and_test_plan
branch
from
207e9bb to
085ad5e
Compare
| [Manual Test] | ||
| 13. Check performance on a large dataset (like IBIS) to make sure the dashboard page displays within a reasonable | ||
| amount of time. | ||
| 13. Check performance on the raisin bread dataset: make sure the dashboard page displays within, say, 5 seconds. |
There was a problem hiding this comment.
| 13. Check performance on the raisin bread dataset: make sure the dashboard page displays within, say, 5 seconds. | |
| 13. Check performance on the raisin bread dataset: make sure the dashboard page displays within 5 seconds. |
Or maybe ' within 5 seconds or less'
|
@driusan There do not seem to be tests for the mri violation widget in the dashboard module, so I have nothing to move. I can issue another PR with tests that cover this. The new PR will also have to fix a bug in the way the widget is created in the mri violations module. |
4 participants
Brief summary of changes
Update of
README.mdandTestPlan.mdfor thestatisticsmodule: addition of documentation and test cases related to the registration of widgets on thedashboardmodule.Testing instructions (if applicable)
N/A
Link(s) to related issue(s)