Skip to content

[imaging_browser] Updated test plan#6472

Merged
driusan merged 4 commits into
aces:23.0-releasefrom
pierre-p-s:2020_05_04_Imaging_Browser_Test_Plan
May 13, 2020
Merged

[imaging_browser] Updated test plan#6472
driusan merged 4 commits into
aces:23.0-releasefrom
pierre-p-s:2020_05_04_Imaging_Browser_Test_Plan

Conversation

@pierre-p-s

@pierre-p-s pierre-p-s commented May 5, 2020

Copy link
Copy Markdown
Contributor

Brief summary of changes

  • Updated the test plan to test the new widgets in the new Access profile module

Link(s) to related issue(s)

@pierre-p-s pierre-p-s added Category: Documentation PR or issue that aims to improve the documentation Testing PR contains test plan or automated test code (or config files for Travis) 23.0.0-testing labels May 5, 2020
christinerogers
christinerogers previously approved these changes May 5, 2020
View reviewed changes
@christinerogers christinerogers added Passed manual tests PR has been successfully tested by at least one peer and removed Passed manual tests PR has been successfully tested by at least one peer labels May 5, 2020
@christinerogers christinerogers dismissed their stale review May 5, 2020 15:41

updating it

christinerogers
christinerogers requested changes May 5, 2020
View reviewed changes

@christinerogers christinerogers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pierre -- this is a good start, could you provide more testing detail, e.g. see the equivalent section from the Media module test plan update:
https://github.com/aces/Loris/pull/6459/files
Also note the name for the module, for consistency I think we're referring to it as the Candidate module, rather than new Access Profiles.

Comment thread modules/imaging_browser/test/TestPlan.md Outdated
Comment thread modules/imaging_browser/test/TestPlan.md Outdated
@pierre-p-s pierre-p-s force-pushed the 2020_05_04_Imaging_Browser_Test_Plan branch from c075b90 to 74281b7 Compare May 6, 2020 01:23
christinerogers
christinerogers requested changes May 6, 2020
View reviewed changes

@christinerogers christinerogers left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates.
Suggested some clarifications and typo fixes.

Not sure but are there no other features in the Widget that are important like--- How many Scans are waiting to be QC'd (or just new Scans)?

Comment thread modules/imaging_browser/test/TestPlan.md Outdated
Comment thread modules/imaging_browser/test/TestPlan.md Outdated
Comment thread modules/imaging_browser/test/TestPlan.md Outdated
@pierre-p-s

pierre-p-s commented May 6, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for your updates.
Suggested some clarifications and typo fixes.

Not sure but are there no other features in the Widget that are important like--- How many Scans are waiting to be QC'd (or just new Scans)?

From what I saw the widget gives a graph of the Scans for each visits. Depending on the color, it displays if the QC passed, failed or 'other'.

christinerogers
christinerogers approved these changes May 6, 2020
View reviewed changes

@christinerogers christinerogers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

driusan
driusan requested changes May 11, 2020
View reviewed changes
Comment thread modules/imaging_browser/test/TestPlan.md
27. Try editing comments (adding new ones, deleting old ones). Click Save and ensure the data is saved.

### Test the Candidate Dashboard widget
28. Go to the candidate dashboard in the candidate module and check the Imaging QC Summary widget.

@driusan driusan May 11, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be missing tests for the user functionality that is described in the widget itself (ie hovering, clicking..)

driusan
driusan reviewed May 11, 2020
View reviewed changes
Comment thread modules/imaging_browser/test/TestPlan.md Outdated

### Test the Candidate Dashboard widget
28. Go to the candidate dashboard in the candidate module and check the Imaging QC Summary widget.
- For each visit, check that the QC status displayed matches the Imaging Browser Module.

@driusan driusan May 11, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing tests for the breakdowns by status

@cmadjar cmadjar assigned driusan and unassigned pierre-p-s May 12, 2020
@driusan driusan merged commit 2176e14 into aces:23.0-release May 13, 2020
@ridz1208 ridz1208 added this to the 23.0.0 milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driusan driusan driusan requested changes
@christinerogers christinerogers christinerogers approved these changes

Assignees

@driusan driusan

Labels

Category: Documentation PR or issue that aims to improve the documentation Testing PR contains test plan or automated test code (or config files for Travis)

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

[imaging_browser] Test plan does not test widgets

4 participants

@pierre-p-s @driusan @christinerogers @ridz1208