Skip to content

[instruments] updated README and test plan for widgets#6484

Merged
driusan merged 10 commits into
aces:23.0-releasefrom
maltheism:instruments_widgets_readme_testplan
Jun 9, 2020
Merged

[instruments] updated README and test plan for widgets#6484
driusan merged 10 commits into
aces:23.0-releasefrom
maltheism:instruments_widgets_readme_testplan

Conversation

@maltheism

Copy link
Copy Markdown
Member

Brief summary of changes

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Read the README.md for the instruments module.
  2. Follow the TestPlan.md instructions for the instruments module.

Link(s) to related issue(s)

@maltheism maltheism added Category: Documentation PR or issue that aims to improve the documentation 23.0.0-testing labels May 7, 2020
@maltheism maltheism linked an issue May 7, 2020 that may be closed by this pull request
Comment thread modules/instruments/test/TestPlan.md Outdated
Comment thread modules/instruments/test/TestPlan.md Outdated
maltheism and others added 2 commits May 7, 2020 16:55
Co-authored-by: PapillonMcGill <34311645+PapillonMcGill@users.noreply.github.com>
Co-authored-by: PapillonMcGill <34311645+PapillonMcGill@users.noreply.github.com>
@maltheism

Copy link
Copy Markdown
Member Author

thanks for the help @PapillonMcGill !

@PapillonMcGill PapillonMcGill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the functionality is all covered and correct.

@ridz1208

ridz1208 commented May 8, 2020

Copy link
Copy Markdown
Collaborator

@maltheism can you make sure there to remove the old sections in the dashboard testplans that are now in the instruments one please

@ridz1208 ridz1208 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that old dashboard testplan is updated accordingly

Comment thread modules/instruments/test/TestPlan.md Outdated

@driusan driusan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment (I haven't reviewed the actual content yet..)

@maltheism maltheism requested review from driusan and ridz1208 May 13, 2020 16:42
@maltheism

Copy link
Copy Markdown
Member Author

@ridz1208 @driusan added the requested changes.

@ridz1208 ridz1208 dismissed their stale review May 13, 2020 16:59

changes addressed

@ridz1208 ridz1208 assigned driusan and unassigned maltheism May 15, 2020
@ridz1208

Copy link
Copy Markdown
Collaborator

@driusan final review

Comment thread modules/instruments/README.md Outdated
Comment thread modules/instruments/test/TestPlan.md
Comment thread modules/instruments/test/TestPlan.md
Comment thread modules/instruments/README.md Outdated
Co-authored-by: Dave MacFarlane <driusan@gmail.com>
@maltheism maltheism requested a review from driusan May 19, 2020 15:49
@ridz1208 ridz1208 added this to the 23.0.0 milestone Jun 8, 2020
@driusan driusan merged commit 1074b20 into aces:23.0-release Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Documentation PR or issue that aims to improve the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[instruments] Widgets are not described in README or test plan

5 participants