[instruments] updated README and test plan for widgets#6484
Merged
driusan merged 10 commits intoJun 9, 2020
Conversation
Co-authored-by: PapillonMcGill <34311645+PapillonMcGill@users.noreply.github.com>
Co-authored-by: PapillonMcGill <34311645+PapillonMcGill@users.noreply.github.com>
Member
Author
|
thanks for the help @PapillonMcGill ! |
PapillonMcGill
approved these changes
May 8, 2020
PapillonMcGill
left a comment
Contributor
There was a problem hiding this comment.
Not sure if the functionality is all covered and correct.
Collaborator
|
@maltheism can you make sure there to remove the old sections in the dashboard testplans that are now in the instruments one please |
ridz1208
previously requested changes
May 8, 2020
ridz1208
left a comment
Collaborator
There was a problem hiding this comment.
Verify that old dashboard testplan is updated accordingly
driusan
reviewed
May 11, 2020
driusan
requested changes
May 11, 2020
driusan
left a comment
Collaborator
There was a problem hiding this comment.
see previous comment (I haven't reviewed the actual content yet..)
Member
Author
Collaborator
|
@driusan final review |
driusan
previously requested changes
May 19, 2020
Co-authored-by: Dave MacFarlane <driusan@gmail.com>
…com/maltheism/Loris into instruments_widgets_readme_testplan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Testing instructions (if applicable)
Link(s) to related issue(s)
[instruments] Widgets are not described in README or test plan #6437