Dev to master 25july #1334
Merged
Dev to master 25july #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing incorrect id issue with checkbox * updating component readme * updating read me
* adding email test * Fixing test collateral * Fixing test collateral * Fixing email test
* updating eventsource while updating model value * Adding ui change event to update model value * Fixing package lock * Fixing text input code --------- Co-authored-by: vdua <vdua@adobe.com>
* Fixing exclusive maximum and minimum issue with number input * Fixing exclusive maximum and minimum issue with date picker * Adding test cases as per the customer use-case * updating package lock * Fixing test case * Fixing test case
* Approval checkbox required by default * FORMS-15481 Adding ui change event to update model value (#1327) * updating eventsource while updating model value * Adding ui change event to update model value * Fixing package lock * Fixing text input code --------- Co-authored-by: vdua <vdua@adobe.com> --------- Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local> Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com> Co-authored-by: vdua <vdua@adobe.com>
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
============================================
- Coverage 81.73% 81.71% -0.03%
- Complexity 853 855 +2
============================================
Files 97 97
Lines 2267 2269 +2
Branches 305 306 +1
============================================
+ Hits 1853 1854 +1
Misses 255 255
- Partials 159 160 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: