Migrated Personalization render functional tests to Vitest+Playwright+MSW#1544
Migrated Personalization render functional tests to Vitest+Playwright+MSW#1544carterworks wants to merge 5 commits into
Conversation
|
|
| Filename | Overview |
|---|---|
| packages/browser/test/integration/specs/Personalization/personalizationRender.spec.js | New integration spec migrating personalization render tests; covers 8 test IDs but the PR description's 'replaced' list claims 11 originals are replaced — 8 of those originals have no counterpart here and are not deleted. |
Sequence Diagram
sequenceDiagram
participant T as Test
participant A as Alloy (browser)
participant M as MSW Handler
participant D as DOM
Note over T,D: C28757 — VEC render
T->>A: configure(alloyConfig)
T->>A: "sendEvent({ renderDecisions: true })"
A->>M: POST /v1/interact (with schemas)
M-->>A: personalization:decisions (dom-action setHtml)
A->>D: "setHtml on #vec-offer-target"
A->>M: POST /v1/interact (display notification)
M-->>A: emptyEventResponse
T->>D: assert innerHTML updated
Note over T,D: C28760 — Display notification
T->>A: "configure + sendEvent (renderDecisions=true)"
A->>M: "interact #1 (with schemas) → proposition"
A->>D: DOM action applied
A->>M: "interact #2 (decisioning.propositionDisplay)"
T->>T: "networkRecorder.findCalls(minCalls=2)"
T->>T: "assert display call has propositionEventType.display=1"
Note over T,D: C17294899 — Consent out
T->>A: "configure(defaultConsent=pending)"
T->>D: assert alloy-prehiding present
T->>A: "setConsent({ general: out })"
A->>M: POST /v1/privacy/set-consent
M-->>A: "state:store (consent=out)"
A->>D: "remove #alloy-prehiding"
T->>D: assert alloy-prehiding absent
Reviews (1): Last reviewed commit: "test(integration): migrate personalizati..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| /* | ||
| Copyright 2026 Adobe. All rights reserved. | ||
| This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. You may obtain a copy | ||
| of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software distributed under | ||
| the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| OF ANY KIND, either express or implied. See the License for the specific language | ||
| governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| /* | ||
| * Covers DOM-rendering aspects migrated from functional tests: | ||
| * | ||
| * C28757 — VEC offer renders (setHtml dom-action) when renderDecisions=true. | ||
| * C28760 — Notification sent after VEC dom-action render. | ||
| * C5805675 — Default content offers delivered with display notification. | ||
| * C14299419 — Prehiding style removed when no personalization payload. | ||
| * C14299420 — Prehiding style removed when renderDecisions=false. | ||
| * C14299422 — Prehiding style removed when personalization payload returned. | ||
| * C17294899 — Prehiding style removed when consent is set to out. | ||
| * C22098199 — Non-idempotent proposition actions not applied multiple times. | ||
| */ | ||
|
|
||
| import { http, HttpResponse } from "msw"; | ||
| // eslint-disable-next-line import/no-unresolved | ||
| import { server } from "vitest/browser"; |
There was a problem hiding this comment.
The PR description lists C14299421, C205528, C205529, C44363, C753469, C753470, C782718, and C782719 as replaced by this file, but none of them have a corresponding test in personalizationRender.spec.js, and none of those source files are removed in this diff. The spec also introduces C28757, C28760, C5805675, C17294899, and C22098199 — none of which appear in the "replaced" list. The PR description should be corrected to reflect the tests actually ported here, and any intentionally deferred originals (redirect offers, CSP-nonce pages, QA Mode) should be documented as skipped with rationale in accordance with the migration plan.
| }; | ||
| }); | ||
|
|
||
| test("alloy-prehiding style is removed even when personalization offer is returned", async ({ | ||
| alloy, | ||
| worker, | ||
| }) => { | ||
| worker.use( | ||
| makeSetHtmlHandler( | ||
| "#prehiding-with-payload-target", | ||
| "Prehiding test content", | ||
| ), | ||
| ); | ||
| await alloy("configure", alloyConfig); | ||
| await alloy("sendEvent", { renderDecisions: true }); | ||
|
|
||
| expect(document.getElementById("alloy-prehiding")).toBeNull(); | ||
| }); | ||
| }); | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // C17294899 — Prehiding style removed when consent is set to out | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| describe("C17294899: prehiding style removed when consent is out", () => { | ||
| beforeEach(() => { | ||
| const style = document.createElement("style"); | ||
| style.id = "alloy-prehiding"; | ||
| style.textContent = "body { visibility: hidden; }"; | ||
| document.head.appendChild(style); | ||
| return () => { | ||
| const existing = document.getElementById("alloy-prehiding"); | ||
| if (existing) existing.parentNode.removeChild(existing); | ||
| }; | ||
| }); | ||
|
|
||
| test("alloy-prehiding style is removed after consent is set to out", async ({ | ||
| alloy, | ||
| worker, | ||
| }) => { | ||
| worker.use(sendEventHandler, setConsentHandler); |
There was a problem hiding this comment.
The original C17294899.js validates two distinct scenarios:
sendEvent(async, consent pending) →setConsent(out)→ prehiding removed ✓ (ported here)- Page reload after consent is stored as "out" →
configurecall itself removes prehiding (not ported)
The second scenario exercises a different code path: Alloy reading a previously-persisted consent cookie at configure-time and proactively removing the prehiding element. If the integration harness can simulate the stored-cookie state without a real reload (by writing the kndctr_…_consent cookie before configure is called), the missing scenario should be added. If a real reload is required, this should be documented as a known gap.
| activity: { id: "idempotency-activity" }, | ||
| characteristics: { | ||
| eventToken: "idempotency-token", | ||
| viewName: "test", | ||
| scopeType: "view", | ||
| }, | ||
| }, | ||
| items: [ | ||
| { | ||
| id: itemId, | ||
| schema: "https://ns.adobe.com/personalization/dom-action", | ||
| data: { | ||
| type: action, | ||
| content, | ||
| selector: `#${containerId}`, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ]; | ||
|
|
||
| ["prependHtml", "appendHtml", "insertBefore", "insertAfter"].forEach( | ||
| (action) => { | ||
| test(`${action} proposition is not applied multiple times`, async ({ | ||
| alloy, | ||
| worker, | ||
| }) => { | ||
| // Set up DOM | ||
| const container = document.createElement("div"); | ||
| container.id = containerId; | ||
| document.body.appendChild(container); | ||
|
|
||
| const contentId = `idempotency-content-${action}`; | ||
|
|
||
| try { | ||
| worker.use(sendEventHandler); | ||
| await alloy("configure", alloyConfig); | ||
|
|
||
| const itemId = `item-${action}-${Date.now()}`; | ||
| const propositions = makePropositions( | ||
| action, | ||
| `<div id="${contentId}">Content via ${action}</div>`, | ||
| itemId, | ||
| ); | ||
|
|
||
| // First application | ||
| await alloy("applyPropositions", { propositions }); | ||
|
|
||
| const firstCount = document.querySelectorAll(`#${contentId}`).length; | ||
| expect(firstCount).toBe(1); | ||
|
|
||
| // Second application should be idempotent | ||
| await alloy("applyPropositions", { propositions }); | ||
|
|
||
| const secondCount = document.querySelectorAll(`#${contentId}`).length; | ||
| expect(secondCount).toBe(1); | ||
| } finally { | ||
| if (container.parentNode) { | ||
| container.parentNode.removeChild(container); | ||
| } | ||
| } | ||
| }); | ||
| }, | ||
| ); | ||
|
|
||
| test("setHtml propositions can be re-rendered multiple times", async ({ | ||
| alloy, | ||
| worker, | ||
| }) => { | ||
| const container = document.createElement("div"); | ||
| container.id = containerId; |
There was a problem hiding this comment.
setHtml re-render test covers behavior marked as failing in the original
The original C22098199.js functional test has an explicit comment on the equivalent assertion: // TODO: This fails, but it should pass. applyPropositions should be able to be called multiple times and work every time. If the underlying Alloy bug hasn't been fixed, the new "setHtml propositions can be re-rendered multiple times" test will consistently fail in CI. Please confirm the bug is resolved, or mark this test as .skip with a reference to the tracking issue until it is.
| expect(displayCall).toBeDefined(); | ||
| expect( | ||
| displayCall.request.body.events[0].xdm._experience.decisioning | ||
| .propositionEventType.display, | ||
| ).toBe(1); | ||
| expect( | ||
| displayCall.request.body.events[0].xdm._experience.decisioning.propositions | ||
| .length, | ||
| ).toBeGreaterThan(0); | ||
| }); | ||
| }); | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // C5805675 — Default content offers delivered with display notification | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| describe("C5805675: default content offers delivered and display notification sent", () => { | ||
| test("default-content-item schema is present and display notification is sent", async ({ | ||
| alloy, | ||
| worker, | ||
| networkRecorder, | ||
| }) => { | ||
| // Use a handler that returns a default-content-item offer | ||
| const defaultContentHandler = http.post( | ||
| /https:\/\/edge.adobedc.net\/ee\/.*\/?v1\/interact/, | ||
| async (req) => { | ||
| const url = new URL(req.request.url); | ||
| if (url.searchParams.get("configId") !== "bc1a10e0-aee4-4e0e-ac5b-cdbb9abbec83") { | ||
| throw new Error("Handler not configured properly"); | ||
| } | ||
| const requestBody = await req.request.json(); | ||
| const hasSchemas = requestBody?.events?.[0]?.query?.personalization?.schemas; | ||
|
|
||
| if (hasSchemas && hasSchemas.length > 0) { | ||
| return HttpResponse.json({ | ||
| requestId: "default-content-test", | ||
| handle: [ | ||
| { | ||
| payload: [{ id: "ecid-123", namespace: { code: "ECID" } }], | ||
| type: "identity:result", | ||
| }, | ||
| { | ||
| payload: [ | ||
| { | ||
| id: "AT:default-content-proposition", | ||
| scope: "__view__", | ||
| scopeDetails: { | ||
| decisionProvider: "TGT", | ||
| activity: { id: "default-content-activity" }, | ||
| experience: { id: "0" }, | ||
| characteristics: { eventToken: "default-content-token" }, | ||
| correlationID: "default-content:0:0", | ||
| }, | ||
| items: [ | ||
| { | ||
| id: "0", | ||
| schema: | ||
| "https://ns.adobe.com/personalization/default-content-item", | ||
| meta: { | ||
| "activity.id": "default-content-activity", | ||
| "activity.name": "Functional: C5805675 AB", | ||
| "experience.id": "0", | ||
| "offer.id": "0", | ||
| "offer.name": "Default Content", | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| type: "personalization:decisions", | ||
| eventIndex: 0, | ||
| }, | ||
| { | ||
| payload: [ | ||
| { key: "kndctr_5BFE274A5F6980A50A495C08_AdobeOrg_cluster", value: "or2", maxAge: 1800 }, | ||
| ], | ||
| type: "state:store", | ||
| }, | ||
| ], | ||
| }); | ||
| } | ||
|
|
||
| return HttpResponse.text( | ||
| await readFile( |
There was a problem hiding this comment.
makeSetHtmlHandler's skeleton
defaultContentHandler inside the C5805675 describe block replicates the exact same structure as makeSetHtmlHandler (URL match, configId check, hasSchemas branch, emptyEventResponse.json fallback) with only the proposition payload differing. A factory function at the top of the file would eliminate ~50 lines of duplication and make future fixtures easier to add.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
carterworks
force-pushed
the
migrate-integration/11-iab
branch
from
bd904d8 to
86474d3
Compare
carterworks
force-pushed
the
migrate-integration/12-personalization-render
branch
from
3af0ffc to
353c04a
Compare
There was a problem hiding this comment.
carterworks has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
carterworks
force-pushed
the
migrate-integration/11-iab
branch
from
86474d3 to
7208bec
Compare
carterworks
force-pushed
the
migrate-integration/12-personalization-render
branch
from
353c04a to
a22e970
Compare
There was a problem hiding this comment.
carterworks has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
carterworks
changed the base branch from
migrate-integration/11-iab
to
migrate-integration/00-infra
There was a problem hiding this comment.
carterworks has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
carterworks
force-pushed
the
migrate-integration/12-personalization-render
branch
4 times, most recently
from
b71c790 to
2d81adc
Compare
carterworks
force-pushed
the
migrate-integration/12-personalization-render
branch
from
2d81adc to
390a147
Compare
carterworks
force-pushed
the
migrate-integration/12-personalization-render
branch
from
390a147 to
cd5917c
Compare
PR #1544 — Personalization Render: Integration Test Migration ReviewVerdict: 🟡 NEEDS WORK — mergeable after addressing request-body assertion drops and the untracked C14299421 coverage gap. The structural migration is correct: DOM cleanup pattern is sound, isolation fixtures are consistent with sibling specs, MSW handlers fire faithfully, and C22098199 hits all 5 subtests. However, three test cases lose meaningful request-shape assertions that the new harness is fully capable of making (the sibling 1. Parity Matrix
Not deleted, not in new spec: PR description mismatch: The description lists 2. Skip JustificationC17294899 reload subtest 🔴 The old spec has two logical phases:
The reload phase is not skipped with justification — it's silently absent. This tests a distinct behavior (consent cookie survives page load). If it's genuinely impossible to test page reload in this harness, a 3. Assertion FidelityC28757 🟡 — Old asserted:
New drops all three. The harness supports C28760 🟡 — Old asserted: notificationRequestBody.events[0].xdm._experience.decisioning.propositions
.eql(notificationPayload) // exact id, scope, scopeDetailsNew only asserts C5805675 🔴 — Test name:
New asserts only C22098199 forEach 🟡 — Old verified 4. Timing / Flake🟢 🟢 🟢 C17294899 correctly checks prehiding is still present during pending consent before asserting removal — avoids the race that would exist with eager assertion. 5. Isolation🟢 🟢 🟢 DOM cleanup: 🟡 C22098199 forEach tests use 6. Hygiene🟢 License header: present, year 2026. 🔴 🟢 🟡 Summary of Blocking Items
|
carterworks
force-pushed
the
migrate-integration/12-personalization-render
branch
from
751b9c5 to
64ea380
Compare
carterworks
force-pushed
the
migrate-integration/12-personalization-render
branch
4 times, most recently
from
bffa05b to
fca9f69
Compare
… Vitest+Playwright+MSW
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…y integration suite Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Keep the original testcafe functional specs alongside the new Vitest+Playwright+MSW integration suite until these migration branches merge, so reviewers retain the pre-migration signal.
carterworks
force-pushed
the
migrate-integration/12-personalization-render
branch
from
fca9f69 to
ea417a3
Compare
1 participant
Changed Packages
Description
Migrates the Personalization render functional tests to the new Vitest+Playwright+MSW harness.
Related Issue
Part of the functional test → integration test migration. See
packages/browser/test/FUNCTIONAL_MIGRATION_PLAN.md.Motivation and Context
The existing TestCafe functional test suite is being migrated to Vitest+Playwright+MSW to enable faster, more reliable CI testing without a running server. This PR is part of a stacked series — each PR migrates one test file.
Functional tests replaced:
packages/browser/test/functional/specs/Personalization/C14299419.jspackages/browser/test/functional/specs/Personalization/C14299420.jspackages/browser/test/functional/specs/Personalization/C14299421.jspackages/browser/test/functional/specs/Personalization/C14299422.jspackages/browser/test/functional/specs/Personalization/C205528.jspackages/browser/test/functional/specs/Personalization/C205529.jspackages/browser/test/functional/specs/Personalization/C44363.jspackages/browser/test/functional/specs/Personalization/C753469.jspackages/browser/test/functional/specs/Personalization/C753470.jspackages/browser/test/functional/specs/Personalization/C782718.jspackages/browser/test/functional/specs/Personalization/C782719.jsTypes of changes
Checklist:
Stack