Added documented stubs for Visitor ID migration functional tests

[carterworks]

Changed Packages

• core
• reactor-extension

Description

All 4 visitor tests preserved as test.skip — require Visitor.js injection infrastructure and OptIn mock not available in the current harness.

Related Issue

Part of the functional test → integration test migration. See packages/browser/test/FUNCTIONAL_MIGRATION_PLAN.md.

Motivation and Context

The existing TestCafe functional test suite is being migrated to Vitest+Playwright+MSW to enable faster, more reliable CI testing without a running server. This PR is part of a stacked series — each PR migrates one test file.

Functional tests replaced:

• packages/browser/test/functional/specs/Visitor/C35448.js
• packages/browser/test/functional/specs/Visitor/C35450.js
• packages/browser/test/functional/specs/Visitor/C36908.js
• packages/browser/test/functional/specs/Visitor/C36909.js

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (non-breaking change which does not add functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have added a Changeset file with a consumer-facing description of my changes.
• I have signed the Adobe Open Source CLA or I'm an Adobe employee.
• I have made any necessary test changes and all tests pass.
• I have run the Sandbox successfully.

Stack

1. Migrated Install SDK functional tests to Vitest+Playwright+MSW #1533
2. Added MSW handlers, mock fixtures, and Vitest+Playwright test harness for functional test migration #1532
3. Added documented stubs for Visitor ID migration functional tests #1552 👈 current

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2b854f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[greptile-apps]

Greptile Summary

This PR adds a new integration test spec file for Visitor ID migration (visitor.spec.js) as part of the ongoing migration from the TestCafe functional suite to Vitest+Playwright+MSW. All four tests (C35448, C35450, C36908, C36909) are registered as test.skip stubs because the Visitor.js page-injection infrastructure and OptIn mock needed to exercise them are not yet available in the integration harness.

• Adds packages/browser/test/integration/specs/Visitor/visitor.spec.js with four skipped stubs preserving test case IDs and skip rationale from the original functional tests.
• No production code is changed; the file is purely additive to the test suite and does not affect runtime behavior.

Confidence Score: 4/5

Safe to merge — the change is purely additive, touching only a new test file with no production code impact.

The file is a straightforward test stub with no runtime effects. The only concerns are that test.skip with empty bodies is slightly less idiomatic than test.todo for unwritten tests, and there is no tracking reference linking back to when the required Visitor.js infrastructure will land to un-skip these tests.

packages/browser/test/integration/specs/Visitor/visitor.spec.js — consider adding a ticket/issue link in the skip comment and evaluating whether test.todo better expresses intent.

Important Files Changed

Filename	Overview
packages/browser/test/integration/specs/Visitor/visitor.spec.js	New file registering four fully-skipped Visitor ID migration test stubs; tests require Visitor.js injection and OptIn mock not yet available in the Vitest+MSW harness.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Visitor ID Migration Tests<br/>C35448, C35450, C36908, C36909] -->|needs| B{Required Infrastructure}
    B -->|missing| C[Visitor.js Page Injection]
    B -->|missing| D[VisitorAPI MSW Handler]
    B -->|missing| E[OptIn Mock]
    C & D & E --> F[test.skip stubs registered no execution]
    F --> G[Integration Test Suite visitor.spec.js]

Loading

_{Reviews (1): Last reviewed commit: "test(integration): migrate visitor funct..." | Re-trigger Greptile}

[greptile-apps]

test.todo more idiomatic for unwritten stubs than test.skip with empty bodies

Vitest's test.todo is purpose-built for "planned but not yet written" tests — it takes only a title string and signals to Vitest (and readers) that no implementation exists yet. test.skip with async () => {} bodies implies an implementation that has been temporarily disabled, which is semantically misleading. Using test.todo would also remove the need for the four // eslint-disable-next-line no-empty-function suppressions.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

No tracking reference for unblocking these tests

The comment documents why the tests are skipped but gives no pointer to a ticket, issue, or follow-up PR that will provide Visitor.js injection infrastructure and the OptIn mock. Without a reference, these stubs risk becoming permanently skipped — especially notable given that C35448 was tagged SEVERITY: "P0" in the original functional suite. Consider linking a tracking issue so the infrastructure gap stays visible.

[greptile-apps]

carterworks has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[greptile-apps]

carterworks has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[greptile-apps]

carterworks has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[carterworks]

Stub PR review — Visitor ID migration (visitor.spec.js)

All four cases are confirmed test.skip stubs. No functional files deleted. One finding; everything else is clean.

---

Stub traceability

C-number	Old functional file	Skip reason in stub
C35448	Visitor/C35448.js	Visitor.js injection + VisitorAPI MSW handler
C35450	Visitor/C35450.js	Visitor.js injection + OptIn mock
C36908	Visitor/C36908.js	Visitor.js injection + OptIn mock
C36909	Visitor/C36909.js	Visitor.js injection + OptIn mock

---

Checks

🟢 All stubs genuine — each test.skip body is async () => {}. No test logic, no assertions, no false "migrated" claim.

🟢 Skip rationale documented — file-level comment at visitor.spec.js:13 gives the shared reason; each stub name repeats the specific blocker inline.

🟢 C-number traceability — all four C-numbers from migrate-integration/00-infra are present and map 1:1.

🟢 Harness wiring — import ../../helpers/testsSetup/extend.js resolves correctly from specs/Visitor/. Registration is glob-based (packages/browser/test/integration/**/*.spec.js in vitest.projects.js:61); the new file is auto-included.

🟢 License header — present, year 2026 matches surrounding new files.

🟢 Functional files not deleted — correct for a stub PR.

🟡 Inherited bug in source material (informational, not a PR defect): C35450.js, C36908.js, and C36909.js in the old functional suite all carry test.meta({ ID: "C35448" }) — a copy-paste error in the originals. The stubs correctly use the right C-numbers in their names, so traceability is preserved. Worth tracking when these get fully implemented.

---

N/A for stub PRs: mock fidelity, timing, network handler coverage, parity with functional assertions — none applicable until implementation.

---

Looks good to merge as-is. The stub-then-implement pattern is being followed correctly here.