fix: #6938 Prevent actionbar dropdown from sliding off at small widths - #10399
fix: #6938 Prevent actionbar dropdown from sliding off at small widths#10399jsmitrah wants to merge 5 commits into
Conversation
| align-items: center; | ||
| min-width: 0; | ||
| isolation: isolate; | ||
| justify-content: space-between; |
There was a problem hiding this comment.
Please explain the changes, because I would not have expected this property to change
There was a problem hiding this comment.
justify-content: space-between: I removed it because it wasn't doing anything.
In this grid, the third column is 1fr, which automatically takes up all the remaining space. Since there's no extra space left, justify-content: space-between has nothing to distribute. So removing it doesn't change the layout or behavior, it was simply unused code.
snowystinger
left a comment
There was a problem hiding this comment.
Thanks for looking into this.
The original issue seems a bit contrived. The absolute smallest screen on mobile is 320px which gives us 278px in the ActionBar which is larger than the size of screen that the issue reports.
I'm going to close the original issue, if there's a real case, we can reopen it with that. We'll handle this in S2 when we implement ActionGroup collapsing.
| grid-template-columns: | ||
| auto max-content minmax(var(--spectrum-global-dimension-size-300), 1fr) | ||
| auto; | ||
| auto minmax(0, max-content) minmax(0, 1fr) |
There was a problem hiding this comment.
We don't want this to shrink down to zero width https://spectrum.adobe.com/page/action-bar/#Safe-zone
Closes #6938
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: