chore(deps): update codecov orb to v3.3.0 - #33
Closed
renovate[bot] wants to merge 1 commit into
Closed
Conversation
|
This PR will trigger no release when merged. |
renovate
Bot
force-pushed
the
renovate/codecov-3.x
branch
from
December 12, 2023 12:45
076a752 to
5f6fb32
Compare
Contributor
Author
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
byteclimber
added a commit
that referenced
this pull request
Jul 28, 2026
Implements serenity-docs#33 on top of the runner mechanics from #186: classifyPromptsHandler (create + reclassify modes), an unbounded retry-with-backoff classifier for the async path, the "no terminal Informational default" behavior in resolveIntentValueInjection/ makeIntentInjector, and CSV-import routing to the async job runner (flat BrandSemrushProject mode only — subworkspace CSV import stays synchronous for now, follow-up flagged in the PR description). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
byteclimber
added a commit
that referenced
this pull request
Jul 29, 2026
## Summary - The `build:worker`/`deploy:worker`/`deploy-stage:worker`/`deploy-dev:worker` npm scripts named the worker Lambda `serenity-prompt-classification` (via `--name=`), but the already-merged `spacecat-infrastructure` Terraform (#708) wired `serenity_job_runner_lambda_function_arn` to `spacecat-services--serenity-job-runner`. - Left as-is, deploying the worker would create a Lambda under a name the event-source-mapping (once `create_serenity_job_runner_esms` is flipped on) can never bind to. - Renames only the `--name` flag to `serenity-job-runner`; the source directory (`src/serenity-prompt-classification/`) and `--entryFile` path are unchanged. ## Context Follow-up to adobe/serenity-docs#186 + #33 ([#2920](#2920), [spacecat-infrastructure#708](adobe/spacecat-infrastructure#708)). Caught while preparing the first manual worker deploy to dev — the naming mismatch was flagged as a non-blocking nit by MysticatBot on #2920 ("Worker directory named `serenity-prompt-classification` for a generic job runner... will be misleading once multiple job types are registered") but not acted on before infra picked the other name. ## Test plan - [x] `grep` confirms all four npm scripts now reference `serenity-job-runner` - [ ] `npm run deploy-dev:worker` deploys `spacecat-services--serenity-job-runner` to dev (to be run once this merges) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
byteclimber
added a commit
that referenced
this pull request
Jul 29, 2026
…2935) ## Summary - Adds a `workflow_dispatch`-only `deploy-worker` job to `.github/workflows/ci.yaml` to build/deploy the serenity job runner's worker Lambda (adobe/serenity-docs#186) — a second Lambda built from a distinct `hedy --entryFile` (`src/serenity-prompt-classification/index.js`, deployed as `spacecat-services--serenity-job-runner`) that the reusable `service-ci` workflow has no seam for (it only knows `deploy-dev`/`deploy-stage` for a single Lambda per service). ## Why workflow_dispatch, not push-triggered - The worker isn't part of steady-state traffic yet — `create_serenity_job_runner_esms` defaults `false` in every environment (spacecat-infrastructure#708), so nothing consumes the queue until that flag flips. - Tying the deploy to every push would add permanent CI surface for a feature not yet in continuous use. - Personal dev credentials lack the `iam:PassRole` permission needed to create/update this Lambda manually (confirmed directly — a manual `hedy` deploy attempt failed with `AccessDenied` on `iam:PassRole` for `spacecat-role-lambda-generic`); CI's `spacecat-role-github-actions` already has it, since it's how the main Lambda deploys today. ## Not included - **Prod** — prod deploys go through `npm run semantic-release` (an exec plugin, not a direct `npm run deploy` call), which doesn't invoke `deploy:worker`. Wiring the worker into the release process is a separate follow-up once it needs continuous prod deployment. ## Usage ``` gh workflow run ci.yaml -f environment=dev # or environment=stage ``` ## Companion PRs adobe/serenity-docs#186 / #33 — [#2920](#2920), [spacecat-infrastructure#708](adobe/spacecat-infrastructure#708), [#2933](#2933) (naming fix) ## Test plan - [x] YAML parses cleanly (`js-yaml` load check) - [ ] `gh workflow run ci.yaml -f environment=dev` successfully deploys `spacecat-services--serenity-job-runner` (to be run once this merges) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.2.2->3.3.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.