Skip to content

MWPW-189482 maintain the height of the carosuel while swiping of the cards#940

Merged
nkthakur48 merged 5 commits intostagefrom
carousel-height
Mar 26, 2026
Merged

MWPW-189482 maintain the height of the carosuel while swiping of the cards#940
nkthakur48 merged 5 commits intostagefrom
carousel-height

Conversation

@suhjainadobe
Copy link
Copy Markdown
Contributor

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 23, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 23, 2026

Page Scores Audits Google
📱 /drafts/suhjain/document58?milolibs=mwpw-189482 Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ /drafts/suhjain/document58?milolibs=mwpw-189482 Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 940: MWPW-189482 maintain the height of the carosuel while swiping of the cards due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 940: MWPW-189482 maintain the height of the carosuel while swiping of the cards due to failing checks

@spadmasa spadmasa self-assigned this Mar 25, 2026
@spadmasa
Copy link
Copy Markdown
Collaborator

fix is verified and results are in jira

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 940: MWPW-189482 maintain the height of the carosuel while swiping of the cards due to failing checks

Comment thread creativecloud/styles/doodlebug.css
Comment thread creativecloud/styles/doodlebug.css
Comment thread creativecloud/styles/doodlebug.css Outdated
@nkthakur48 nkthakur48 added the question Further information is requested label Mar 26, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.46%. Comparing base (f6343b0) to head (9b96984).
⚠️ Report is 20 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #940      +/-   ##
==========================================
+ Coverage   88.37%   88.46%   +0.08%     
==========================================
  Files          42       42              
  Lines        9277     9249      -28     
==========================================
- Hits         8199     8182      -17     
+ Misses       1078     1067      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nkthakur48 nkthakur48 removed the question Further information is requested label Mar 26, 2026
@nkthakur48 nkthakur48 merged commit e228c08 into stage Mar 26, 2026
7 of 8 checks passed
nkthakur48 added a commit to adobecom/da-cc that referenced this pull request Mar 27, 2026
…cards (adobecom#940)

* maintain the height of the carosuel while swiping of the cards

* review comments

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
nkthakur48 added a commit that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants