Skip to content

MWPW-189680 [Doodlebug] Add support for video in firefly-carousel#935

Merged
nkthakur48 merged 5 commits intostagefrom
MWPW-189680-ff-carousel-video
Mar 17, 2026
Merged

MWPW-189680 [Doodlebug] Add support for video in firefly-carousel#935
nkthakur48 merged 5 commits intostagefrom
MWPW-189680-ff-carousel-video

Conversation

@nkthakur48
Copy link
Copy Markdown
Collaborator

@nkthakur48 nkthakur48 commented Mar 16, 2026 •
edited
Loading

  • Add Firefly Carousel support for video slides by parsing and rendering .video-container.video-holder media element (in addition to pictures).
  • Improve carousel accessibility by syncing video pause/play control tab order with the active slide and placing the prompt pill before media controls when present.
  • Improve slide parsing to support nested block structures and skip invalid items missing media or deeplink anchors.
  • Add video source fallback logic to populate video.src from data-video-source when no src/source is present.
  • Update carousel media CSS so image/video/video containers consistently fill the slide area and normalize video container layout.

Resolves: MWPW-189680

Test URLs:

Dev validation

video-support-ff-carousel-a11y-compressed.mp4

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 16, 2026 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 16, 2026 •
edited
Loading

Page Scores Audits Google
📱 /drafts/doodlebug/video-generator-video-carousel?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/doodlebug/video-generator-video-carousel?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync Bot temporarily deployed to MWPW-189680-ff-carousel-video March 16, 2026 09:15 Inactive
@aem-code-sync aem-code-sync Bot temporarily deployed to MWPW-189680-ff-carousel-video March 16, 2026 09:23 Inactive
@aem-code-sync aem-code-sync Bot temporarily deployed to MWPW-189680-ff-carousel-video March 16, 2026 09:35 Inactive
suhjainadobe
suhjainadobe requested changes Mar 16, 2026
View reviewed changes
Comment thread creativecloud/blocks/firefly-carousel/firefly-carousel.js Outdated
@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Mar 16, 2026

Skipped merging 935: MWPW-189680 [Doodlebug] Add support for video in firefly-carousel due to failing checks

@hkuraware hkuraware requested a review from suhjainadobe March 17, 2026 04:44
@nkthakur48 nkthakur48 merged commit ccbf9e1 into stage Mar 17, 2026
8 of 10 checks passed
nkthakur48 added a commit to adobecom/da-cc that referenced this pull request Mar 17, 2026
@nkthakur48
MWPW-189680 [Doodlebug] Add support for video in firefly-carousel (ad…
74a4b1e 
…obecom#935)

* MWPW-189680 [Doodlebug] Add support for video in firefly-carousel

* MWPW-189680 [Doodlebug] Improve firefly-carousel prompt placement and video control tab order

* MWPW-189680: Updated MEDIA_SELECTOR

* MWPW-189680 Removed redundant fall-back

* MWPW-189680: Corrected selector for parseItemsFromDOM
@nkthakur48 nkthakur48 mentioned this pull request Mar 17, 2026
Merged
nkthakur48 added a commit to adobecom/da-cc that referenced this pull request Mar 17, 2026
@nkthakur48
[Release] Stage to Main 03/17
b6ea242 
- #14
- #15
- #17
- adobecom#862
- adobecom#870
- adobecom#873
- adobecom#881
- adobecom#883
- adobecom#885
- adobecom#886
- adobecom#887
- adobecom#889
- adobecom#890
- adobecom#891
- adobecom#893
- adobecom#895
- adobecom#896
- adobecom#899
- adobecom#901
- adobecom#902
- adobecom#903
- adobecom#904
- adobecom#905
- adobecom#906
- adobecom#907
- adobecom#908
- adobecom#909
- adobecom#910
- adobecom#911
- adobecom#913
- adobecom#917
- adobecom#918
- adobecom#920
- adobecom#921
- adobecom#924
- adobecom#926
- adobecom#927
- adobecom#928
- adobecom#929
- adobecom#930
- adobecom#932
- adobecom#933
- adobecom#935
@milo-pr-merge-cc milo-pr-merge-cc Bot mentioned this pull request Mar 25, 2026
Merged
nkthakur48 added a commit that referenced this pull request Mar 30, 2026
@nkthakur48
[Release] Stage to Main 03/30
e9975df 
- #955
- #953
- #952
- #940
- #950
- #944
- #938
- #916
- #937
- #947
- #948
- #945
- #942
- #941
- #939
- #934
- #935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drashti1712 drashti1712 drashti1712 approved these changes

@suhjainadobe suhjainadobe suhjainadobe approved these changes

@hkuraware hkuraware hkuraware approved these changes

@hkhatana26 hkhatana26 Awaiting requested review from hkhatana26

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nkthakur48 @drashti1712 @suhjainadobe @hkuraware