[MWPW-191014]: RTL support for play/pause in firefly carousel#952
Merged
nkthakur48 merged 5 commits intostagefrom Mar 26, 2026
Merged
[MWPW-191014]: RTL support for play/pause in firefly carousel#952nkthakur48 merged 5 commits intostagefrom
nkthakur48 merged 5 commits intostagefrom
Conversation
hkuraware
requested review from
drashti1712,
hkhatana26,
nkthakur48 and
suhjainadobe
nkthakur48
reviewed
Mar 26, 2026
| } | ||
|
|
||
| /* Video play/pause button */ | ||
| [dir="rtl"] .video-container .pause-play-wrapper { |
Collaborator
There was a problem hiding this comment.
Nit: You could skip the comment, it's self-evident from the class-names
Collaborator
Author
There was a problem hiding this comment.
@nkthakur48 ,
Makes sense, I added it just to call out that it's the only other selector besides .firefly-carousel, but I'm good to remove it.
Collaborator
|
As confirmed by @hkuraware , overlay issues even for RTL will be fixed by #950 |
nkthakur48
approved these changes
Mar 26, 2026
hkhatana26
approved these changes
Mar 26, 2026
Collaborator
Collaborator
|
@spadmasa You got me worried when you closed the PR :) |
nkthakur48
added a commit
to adobecom/da-cc
that referenced
this pull request
Mar 27, 2026
…om#952) * Fixed rtl for video play/pause button * Removed comment --------- Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
nkthakur48
added a commit
to adobecom/da-cc
that referenced
this pull request
Apr 6, 2026
**adobecom/da-cc** - #25 - #20 - #19 - #18 **adobecom/cc** - adobecom#916 - adobecom#934 - adobecom#938 - adobecom#939 - adobecom#940 - adobecom#941 - adobecom#942 - adobecom#944 - adobecom#945 - adobecom#947 - adobecom#948 - adobecom#950 - adobecom#952 - adobecom#953 - adobecom#955
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-191014
Test URLs:
Dev validation:
Before:-
After:-
RTL:
LTR:
