✨ amp-story-shopping-config data json handle get and set config data#36757
Merged
jshamble merged 57 commits intoampproject:mainfrom Nov 18, 2021
Merged
✨ amp-story-shopping-config data json handle get and set config data#36757jshamble merged 57 commits intoampproject:mainfrom
jshamble merged 57 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: Hey @newmuis! These files were changed: |
jshamble
requested review from
coreymasanto and
processprocess
and removed request for
mszylkowski
processprocess
requested changes
Nov 4, 2021
Contributor
processprocess
left a comment
processprocess
left a comment
There was a problem hiding this comment.
Looking good. Lots of little comments but this is a big PR with lots of good work!
processprocess
requested changes
Nov 4, 2021
Contributor
processprocess
left a comment
processprocess
left a comment
There was a problem hiding this comment.
Awesome progress! Some nits and comments.
processprocess
requested changes
Nov 4, 2021
Contributor
processprocess
left a comment
processprocess
left a comment
There was a problem hiding this comment.
A few more nits and changes. Looking awesome!
Please be sure to update the visual diff test with JSON data too!
examples/visual-tests/amp-story/amp-story-shopping.html
gmajoulet
reviewed
Nov 15, 2021
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-config.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-config.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-tag.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-tag.js
Outdated
Show resolved
Hide resolved
extensions/amp-story/1.0/test/test-amp-story-request-service.js
Outdated
Show resolved
Hide resolved
processprocess
approved these changes
Nov 17, 2021
coreymasanto
approved these changes
Nov 17, 2021
Contributor
coreymasanto
left a comment
coreymasanto
left a comment
There was a problem hiding this comment.
I have a few last comments, but this PR otherwise looks good to me!
gmajoulet
reviewed
Nov 17, 2021
Contributor
gmajoulet
left a comment
gmajoulet
left a comment
There was a problem hiding this comment.
last 2 nits! Looking awesome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles loading and setting amp story config data using the store Service.
Updates the tag to display keyed by their product tag ID.
Fixes #36699
Fixes #36911