Skip to content

Migrate LLM compaction tail tests#26734

Merged
kitlangton merged 1 commit into
devfrom
cleanup/compaction-llm-tail-effect-tests
May 10, 2026
Merged

Migrate LLM compaction tail tests#26734
kitlangton merged 1 commit into
devfrom
cleanup/compaction-llm-tail-effect-tests

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented May 10, 2026

Summary

  • Convert two LLM-backed compaction tail tests to it.instance and yielded services.
  • Extend the compaction process test layer helper to cover LLM-backed processors.
  • Keep per-test LLM/config variation local with Effect.provide(compactionProcessLayer(...)).

Testing

  • bun test --timeout 5000 test/session/compaction.test.ts -t "falls back to full summary when retained tail media|retains a split turn suffix|falls back to full summary when even one recent turn"
  • bun typecheck from packages/opencode
  • bunx prettier --check packages/opencode/test/session/compaction.test.ts
  • bunx oxlint packages/opencode/test/session/compaction.test.ts (existing warnings only, no errors)

Stack

  1. Migrate configurable compaction tests #26732
  2. Migrate compaction LLM test #26733
  3. Migrate LLM compaction tail tests #26734 👈 current
  4. Migrate compaction plugin test #26736
  5. Migrate compaction tool-call test #26737
  6. Replace compaction create test fixtures #26738
  7. Drop compaction create facade #26739
  8. Drop unused ID Zod statics #26740
  9. Simplify compaction test helpers #26742

@kitlangton kitlangton force-pushed the cleanup/compaction-llm-effect-tests branch from 5130dc7 to edd230d Compare May 10, 2026 23:08
@kitlangton kitlangton force-pushed the cleanup/compaction-llm-tail-effect-tests branch from db08c7b to 267601c Compare May 10, 2026 23:08
@kitlangton kitlangton force-pushed the cleanup/compaction-llm-effect-tests branch from edd230d to ce1d8da Compare May 10, 2026 23:13
@kitlangton kitlangton force-pushed the cleanup/compaction-llm-tail-effect-tests branch from 267601c to 19cab47 Compare May 10, 2026 23:13
@kitlangton kitlangton force-pushed the cleanup/compaction-llm-effect-tests branch from ce1d8da to d35c264 Compare May 10, 2026 23:18
@kitlangton kitlangton force-pushed the cleanup/compaction-llm-tail-effect-tests branch from 19cab47 to 6f775d1 Compare May 10, 2026 23:18
@kitlangton kitlangton changed the base branch from cleanup/compaction-llm-effect-tests to dev May 10, 2026 23:20
@kitlangton kitlangton force-pushed the cleanup/compaction-llm-tail-effect-tests branch from 6f775d1 to c0f65d5 Compare May 10, 2026 23:20
@kitlangton kitlangton merged commit ca8a42c into dev May 10, 2026
12 checks passed
@kitlangton kitlangton deleted the cleanup/compaction-llm-tail-effect-tests branch May 10, 2026 23:41
joshue031 pushed a commit to joshue031/opencode that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant