Skip to content

Drop unused ID Zod statics#26740

Merged
kitlangton merged 1 commit into
devfrom
cleanup/drop-unused-id-zod-statics
May 10, 2026
Merged

Drop unused ID Zod statics#26740
kitlangton merged 1 commit into
devfrom
cleanup/drop-unused-id-zod-statics

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented May 10, 2026

Summary

  • Remove unused .zod statics from simple session/workspace ID schemas.
  • Convert TUI session ID validation to Effect Schema decoding.
  • Update schema decoding tests to use Effect decoders for IDs without Zod statics.

Testing

  • bun test --timeout 5000 test/session/schema-decoding.test.ts test/session/compaction.test.ts -t "summarizes only the head|anchors repeated compactions|keeps recent pre-compaction|ignores previous summaries|accepts minimal session"
  • bun typecheck from packages/opencode
  • bunx prettier --check packages/opencode/src/cli/cmd/tui/validate-session.ts packages/opencode/src/session/schema.ts packages/opencode/src/control-plane/schema.ts packages/opencode/test/session/schema-decoding.test.ts packages/opencode/test/session/compaction.test.ts
  • bunx oxlint packages/opencode/src/cli/cmd/tui/validate-session.ts packages/opencode/src/control-plane/schema.ts packages/opencode/src/session/schema.ts packages/opencode/test/session/schema-decoding.test.ts

Stack

  1. Migrate configurable compaction tests #26732
  2. Migrate compaction LLM test #26733
  3. Migrate LLM compaction tail tests #26734
  4. Migrate compaction plugin test #26736
  5. Migrate compaction tool-call test #26737
  6. Replace compaction create test fixtures #26738
  7. Drop compaction create facade #26739
  8. Drop unused ID Zod statics #26740 👈 current
  9. Simplify compaction test helpers #26742

@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch 2 times, most recently from f419632 to 38631fd Compare May 10, 2026 17:31
@kitlangton kitlangton force-pushed the cleanup/drop-compaction-create-facade branch from fe61f1c to b891277 Compare May 10, 2026 23:08
@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch from 38631fd to 6056522 Compare May 10, 2026 23:08
@kitlangton kitlangton force-pushed the cleanup/drop-compaction-create-facade branch from b891277 to 868c00c Compare May 10, 2026 23:13
@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch from 6056522 to bfce366 Compare May 10, 2026 23:13
@kitlangton kitlangton force-pushed the cleanup/drop-compaction-create-facade branch from 868c00c to 3598994 Compare May 10, 2026 23:18
@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch from bfce366 to 6ba5c90 Compare May 10, 2026 23:18
@kitlangton kitlangton force-pushed the cleanup/drop-compaction-create-facade branch from 3598994 to b438f73 Compare May 10, 2026 23:21
@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch from 6ba5c90 to 5e9f49f Compare May 10, 2026 23:21
@kitlangton kitlangton force-pushed the cleanup/drop-compaction-create-facade branch from b438f73 to 08dc6bf Compare May 10, 2026 23:41
@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch from 5e9f49f to d762c80 Compare May 10, 2026 23:41
@kitlangton kitlangton force-pushed the cleanup/drop-compaction-create-facade branch from 08dc6bf to 327d764 Compare May 10, 2026 23:42
@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch from d762c80 to 609d313 Compare May 10, 2026 23:42
@kitlangton kitlangton force-pushed the cleanup/drop-compaction-create-facade branch from 327d764 to a5b73f9 Compare May 10, 2026 23:44
@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch from 609d313 to a973fd4 Compare May 10, 2026 23:44
@kitlangton kitlangton force-pushed the cleanup/drop-compaction-create-facade branch from a5b73f9 to a51ad58 Compare May 10, 2026 23:53
@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch from a973fd4 to 920b7a9 Compare May 10, 2026 23:53
@kitlangton kitlangton changed the base branch from cleanup/drop-compaction-create-facade to dev May 10, 2026 23:54
@kitlangton kitlangton force-pushed the cleanup/drop-unused-id-zod-statics branch from 920b7a9 to 656ba20 Compare May 10, 2026 23:54
@kitlangton kitlangton merged commit 5ef72e1 into dev May 10, 2026
9 checks passed
@kitlangton kitlangton deleted the cleanup/drop-unused-id-zod-statics branch May 10, 2026 23:58
joshue031 pushed a commit to joshue031/opencode that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant