Skip to content

Replace compaction create test fixtures#26738

Merged
kitlangton merged 1 commit into
devfrom
cleanup/compaction-create-fixture
May 10, 2026
Merged

Replace compaction create test fixtures#26738
kitlangton merged 1 commit into
devfrom
cleanup/compaction-create-fixture

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented May 10, 2026

Summary

  • Replace remaining SessionCompaction.create(...) setup calls in compaction tests with a test-local compaction marker fixture.
  • Keep tests focused on process behavior without depending on the promise facade.

Testing

  • bun test --timeout 5000 test/session/compaction.test.ts -t "summarizes only the head|anchors repeated compactions|keeps recent pre-compaction|ignores previous summaries|does not allow tool calls"
  • bun typecheck from packages/opencode
  • bunx prettier --check packages/opencode/test/session/compaction.test.ts
  • bunx oxlint packages/opencode/test/session/compaction.test.ts (existing warnings only, no errors)

Stack

  1. Migrate configurable compaction tests #26732
  2. Migrate compaction LLM test #26733
  3. Migrate LLM compaction tail tests #26734
  4. Migrate compaction plugin test #26736
  5. Migrate compaction tool-call test #26737
  6. Replace compaction create test fixtures #26738 👈 current
  7. Drop compaction create facade #26739
  8. Drop unused ID Zod statics #26740
  9. Simplify compaction test helpers #26742

@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from 6539273 to db6f940 Compare May 10, 2026 23:08
@kitlangton kitlangton force-pushed the cleanup/compaction-create-fixture branch from c760e81 to efa5ce9 Compare May 10, 2026 23:08
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from db6f940 to 3f1fde3 Compare May 10, 2026 23:13
@kitlangton kitlangton force-pushed the cleanup/compaction-create-fixture branch from efa5ce9 to db3b1be Compare May 10, 2026 23:13
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from 3f1fde3 to 96de156 Compare May 10, 2026 23:18
@kitlangton kitlangton force-pushed the cleanup/compaction-create-fixture branch from db3b1be to f08e2e6 Compare May 10, 2026 23:18
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from 96de156 to 1350a1c Compare May 10, 2026 23:20
@kitlangton kitlangton force-pushed the cleanup/compaction-create-fixture branch from f08e2e6 to 1e8f0c7 Compare May 10, 2026 23:20
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from 1350a1c to aa370ea Compare May 10, 2026 23:41
@kitlangton kitlangton force-pushed the cleanup/compaction-create-fixture branch from 1e8f0c7 to cea9a80 Compare May 10, 2026 23:41
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from aa370ea to 88acc45 Compare May 10, 2026 23:42
@kitlangton kitlangton force-pushed the cleanup/compaction-create-fixture branch from cea9a80 to 1024a8a Compare May 10, 2026 23:42
@kitlangton kitlangton changed the base branch from cleanup/compaction-repeated-effect-tests to dev May 10, 2026 23:44
@kitlangton kitlangton force-pushed the cleanup/compaction-create-fixture branch from 1024a8a to d8646e4 Compare May 10, 2026 23:44
@kitlangton kitlangton merged commit f71fb18 into dev May 10, 2026
10 checks passed
@kitlangton kitlangton deleted the cleanup/compaction-create-fixture branch May 10, 2026 23:53
joshue031 pushed a commit to joshue031/opencode that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant