Skip to content

Migrate compaction tool-call test#26737

Merged
kitlangton merged 1 commit into
devfrom
cleanup/compaction-repeated-effect-tests
May 10, 2026
Merged

Migrate compaction tool-call test#26737
kitlangton merged 1 commit into
devfrom
cleanup/compaction-repeated-effect-tests

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented May 10, 2026

Summary

  • Convert the summary tool-call guard test to it.instance and yielded services.
  • Reuse the LLM-capable compaction process layer helper introduced in the stack.

Testing

  • bun test --timeout 5000 test/session/compaction.test.ts -t "does not allow tool calls while generating the summary"
  • bun test --timeout 5000 test/session/compaction.test.ts -t "does not allow tool calls while generating the summary|allows plugins to disable synthetic continue prompt"
  • bun typecheck from packages/opencode
  • bunx prettier --check packages/opencode/test/session/compaction.test.ts
  • bunx oxlint packages/opencode/test/session/compaction.test.ts (existing warnings only, no errors)

Stack

  1. Migrate configurable compaction tests #26732
  2. Migrate compaction LLM test #26733
  3. Migrate LLM compaction tail tests #26734
  4. Migrate compaction plugin test #26736
  5. Migrate compaction tool-call test #26737 👈 current
  6. Replace compaction create test fixtures #26738
  7. Drop compaction create facade #26739
  8. Drop unused ID Zod statics #26740
  9. Simplify compaction test helpers #26742

@kitlangton kitlangton force-pushed the cleanup/compaction-plugin-effect-tests branch from e3317c4 to 9f0cff9 Compare May 10, 2026 23:08
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from 6539273 to db6f940 Compare May 10, 2026 23:08
@kitlangton kitlangton force-pushed the cleanup/compaction-plugin-effect-tests branch from 9f0cff9 to 4d2edc9 Compare May 10, 2026 23:13
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from db6f940 to 3f1fde3 Compare May 10, 2026 23:13
@kitlangton kitlangton force-pushed the cleanup/compaction-plugin-effect-tests branch from 4d2edc9 to a85c829 Compare May 10, 2026 23:18
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from 3f1fde3 to 96de156 Compare May 10, 2026 23:18
@kitlangton kitlangton force-pushed the cleanup/compaction-plugin-effect-tests branch from a85c829 to 3a6cf6d Compare May 10, 2026 23:20
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from 96de156 to 1350a1c Compare May 10, 2026 23:20
@kitlangton kitlangton force-pushed the cleanup/compaction-plugin-effect-tests branch from 3a6cf6d to ee20a5f Compare May 10, 2026 23:41
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from 1350a1c to aa370ea Compare May 10, 2026 23:41
@kitlangton kitlangton changed the base branch from cleanup/compaction-plugin-effect-tests to dev May 10, 2026 23:42
@kitlangton kitlangton force-pushed the cleanup/compaction-repeated-effect-tests branch from aa370ea to 88acc45 Compare May 10, 2026 23:42
@kitlangton kitlangton merged commit 64dde0c into dev May 10, 2026
8 checks passed
@kitlangton kitlangton deleted the cleanup/compaction-repeated-effect-tests branch May 10, 2026 23:44
joshue031 pushed a commit to joshue031/opencode that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant