Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug preventing wait_condition from being respected when using apply #61493

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@fabianvf
Copy link
Contributor

commented Aug 28, 2019

SUMMARY

Passes condition on when using apply

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s

ADDITIONAL INFORMATION

@fabianvf fabianvf referenced this pull request Aug 28, 2019
@ansibot

This comment has been minimized.

@willthames
Copy link
Contributor

left a comment

Test suite passes for me. Would be good to have a test that would have caught this bug.

@willthames

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

This will need backporting to 2.9 now that we're frozen

@ansibot ansibot removed the needs_triage label Aug 30, 2019

@fabianvf

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@willthames yeah I updated the tests in #61466 (which is where I pulled this commit from), I can pull that specific test update out as well

@gundalow

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Given tests are in progress in #61466 I think this OK to merge

Once merged please create a backport (inc changelog/fragment) for stable-2.9

@gundalow gundalow added the pr_day label Sep 3, 2019

@fabianvf

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Components

lib/ansible/module_utils/k8s/raw.py
support: community
maintainers: chouseknecht fabianvf flaper87 maxamillion willthames

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): fabianvf
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@willthames willthames merged commit f406b8b into ansible:devel Sep 5, 2019

1 check passed

Shippable Run 140698 status is SUCCESS.
Details
fabianvf added a commit to fabianvf/ansible that referenced this pull request Sep 5, 2019
abadger added a commit that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.